Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs Struct#initialize warns about passing only keyword arguments #947

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Add specs Struct#initialize warns about passing only keyword arguments #947

merged 1 commit into from
Oct 7, 2022

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Oct 3, 2022

Hello 👋

This is my proposal to cover

Passing only keyword arguments to Struct#initialize is warned. You need to use a Hash literal to set a Hash to a first member. Feature #16806

from

Let me know if I can do anything to improve it.

Thank you!

eregon
eregon approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 22bb5b2 into ruby:master Oct 7, 2022
@ohbarye ohbarye mentioned this pull request Oct 7, 2022
Closed
@lxxxvi lxxxvi deleted the Struct-initialize-warns-passing-only-keyword-arguments branch January 12, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxxxvi @eregon