Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.1: Calls without methods inside endless methods #952

Merged

Conversation

EduardoGHdez
Copy link
Contributor

@EduardoGHdez EduardoGHdez commented Oct 8, 2022

Adding test for Feature #17398

A command syntax is allowed in endless method definitions, i.e., you can now write

def foo = puts "Hello"

From: #923

@eregon
Copy link
Member

eregon commented Oct 8, 2022

There are some CI failures on linux/macos caused by this PR, can you address them?

@EduardoGHdez
Copy link
Contributor Author

There are some CI failures on linux/macos caused by this PR, can you address them?

Sure thing 👍

@eregon
Copy link
Member

eregon commented Oct 15, 2022

@EduardoGHdez Could you take a look?

A command syntax is allowed in endless method definitions, i.e.,
you can now write

```
def foo = puts "Hello"
```
@EduardoGHdez EduardoGHdez force-pushed the enless-methods-without-parenthesis-calls branch from a1c89cd to b9cd18e Compare October 21, 2022 21:14
@EduardoGHdez
Copy link
Contributor Author

@eregon Sorry for the delay. But just fixed the specs 🙌🏽

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eregon eregon merged commit 70c8a7b into ruby:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants