-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add specs for Data.define
#995
Conversation
Yeah the docs are wrong, it's on purpose not there and a legacy thing of |
This reminds I should create an issue to track specs for 3.2 😅 |
4a03d70
to
d34014d
Compare
@eregon I applied the changes you suggested, let me know if something is missing or can be improved. Thanks a lot. |
I just saw that the documentation has already been updated on master Will this be updated in the docs when 3.2.1 is released, or earlier? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Done now: #1016 |
Hello again 👋
Here's an attempt for
Data.define
that is related to:I got confused by the Documentation (https://docs.ruby-lang.org/en/3.2/Data.html) that says
I believe the
define(name, *symbols)
is either wrongly documented or not implented. If I read the discussion about the Feature correctly (https://bugs.ruby-lang.org/issues/16122 ), it's not supposed to be implemented, do you agree?I added a failing test for it nonetheless.
As always, thank you very much for your review. Let me know what else I can improve. 🙌