Merge pull request #232 from ruby/schneems/fix-run-on-sentence

Fix missing line break due to puts logic

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## HEAD (unreleased)
 
+- Fix: Separate multiple parser errors by newline. (https://github.com/ruby/syntax_suggest/pull/232)
+
 ## 2.0.1
 
 - Fix CLI failure when shipped with default gems. (https://github.com/ruby/syntax_suggest/pull/226 and https://github.com/ruby/syntax_suggest/pull/227)

lib/syntax_suggest/api.rb

@@ -227,6 +227,7 @@ def self.valid?(source)
 require_relative "code_line"
 require_relative "code_block"
 require_relative "block_expand"
+require_relative "mini_stringio"
 require_relative "priority_queue"
 require_relative "unvisited_lines"
 require_relative "around_block_scan"

lib/syntax_suggest/core_ext.rb

@@ -3,24 +3,6 @@
 # Ruby 3.2+ has a cleaner way to hook into Ruby that doesn't use `require`
 if SyntaxError.method_defined?(:detailed_message)
   module SyntaxSuggest
-    # Mini String IO [Private]
-    #
-    # Acts like a StringIO with reduced API, but without having to require that
-    # class.
-    class MiniStringIO
-      def initialize(isatty: $stderr.isatty)
-        @string = +""
-        @isatty = isatty
-      end
-
-      attr_reader :isatty
-      def puts(value = $/, **)
-        @string << value
-      end
-
-      attr_reader :string
-    end
-
     # SyntaxSuggest.module_for_detailed_message [Private]
     #
     # Used to monkeypatch SyntaxError via Module.prepend

lib/syntax_suggest/mini_stringio.rb

@@ -0,0 +1,24 @@
+module SyntaxSuggest
+  # Mini String IO [Private]
+  #
+  # Acts like a StringIO with reduced API, but without having to require that
+  # class.
+  class MiniStringIO
+    EMPTY_ARG = Object.new
+
+    def initialize(isatty: $stderr.isatty)
+      @string = +""
+      @isatty = isatty
+    end
+
+    attr_reader :isatty
+    def puts(value = EMPTY_ARG, **)
+      if !value.equal?(EMPTY_ARG)
+        @string << value
+      end
+      @string << $/
+    end
+
+    attr_reader :string
+  end
+end

spec/unit/mini_stringio_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require_relative "../spec_helper"
+
+module SyntaxSuggest
+  RSpec.describe "MiniStringIO" do
+    it "#puts with no inputs" do
+      io = MiniStringIO.new
+      io.puts
+      expect(io.string).to eq($/)
+    end
+
+    it "#puts with an input" do
+      io = MiniStringIO.new
+      io.puts "Hello"
+      expect(io.string).to eq(["Hello", $/].join)
+    end
+
+    it "#puts with an input with a newline" do
+      io = MiniStringIO.new
+      io.puts "Hello\n"
+      expect(io.string).to eq(["Hello\n", $/].join)
+    end
+  end
+end