-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of defunct build platforms and runtimes #2123
base: master
Are you sure you want to change the base?
Remove mentions of defunct build platforms and runtimes #2123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ko translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ko 👍
PT translations is fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with zh_tw and zh_cn.
@bugtender GitHub's approval list still says: "ruby/www-ruby-lang-org-i18n-zh_cn was requested for review" - do you know how that can be marked accepted? |
Looking good, I added a comment regarding removing the trailing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID translations is good to go
tr/about/index.md
Outdated
|
||
* Ruby yüksek taşınabilirliğe sahiptir. GNU/Linux üzerinde geliştirilmiş | ||
olsa dahi, UNIX’in bir çok çeşidi, macOS, | ||
Windows, DOS, BeOS, OS/2, vb. üzerinde çalışmaktadır. | ||
Windows, vb. üzerinde çalışmaktadır. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonjensen vb.
means is etc
in Turkish. Is there any operating system except Unix distributions, macOSX or Windows? In English it is It runs under Linux and other UNIX-like operating systems, macOS and Windows
there is no etc so we should not use vb.
in here. It should be in Turkish Ruby yüksek taşınabilirliğe sahiptir. GNU/Linux üzerinde geliştirilmiş olsa dahi, UNIX’in bir çok çeşidi, macOS ve Windows üzerinde çalışmaktadır.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense.
en/about/index.md
Outdated
* Ruby features OS independent threading. Thus, for all platforms on | ||
which Ruby runs, you also have multithreading, regardless of if the OS | ||
supports it or not, even on MS-DOS! | ||
supports it or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
The current ruby (maybe from 1.9 and later) depend on pthread/WinThread to implement Thread.
The whole description in this section is totally false for recent ruby and could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's fine with me. It was already gone from the French version. I removed it from all the others.
Hey @jonjensen and @ruby/www-ruby-lang-org-editorial, what's the status of this pull request? I can work on the Spanish translations of it. |
@gfvcastro The status is that a simple documentation update change requested almost 4 years ago stalled out. 😞 IMO it should just be applied as is, and people can do new pull requests for various languages as they get to them. |
@jonjensen I agree with you. @ruby/www-ruby-lang-org-editorial, what do you think? |
@gfvcastro @jonjensen if someone wants to rebase and include Nagachika-san's suggestion, I think it could be approved: |
fed9fe5
to
d57ef3f
Compare
Ok, rebased, and updated to remove outdated threading notes as per Nagachika-san. |
@@ -174,13 +171,6 @@ MRI以外のRuby処理系には以下のようなものがあります。 | |||
* [mruby][mruby]はRubyの軽量実装です。アプリケーションにリンクし、組み込むことができます。Rubyの作者であるまつもと ゆきひろ氏によって開発が進められています。 | |||
* [truffleruby][truffleruby]はGraalVM上に構築された高速なRuby実装です。 | |||
|
|||
#### 以下のバージョンはここ数年ほとんどまたは全く更新されていませんが、引き続き利用可能です。 | |||
|
|||
* [Rubinius][rubinius]は「Rubyで書かれたRuby」です。LLVM上に構築されています。LLVMは他の言語も構築されるよくできた仮想マシンです。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess deletion of this line is not intentional, because no other translations in this pull request does the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shyouhei It was intentional. The other translations don't have that at all. They didn't separate frequently-updated from less-updated.
I removed that line because all the less-frequently-updated ones are totally dead now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, got it. Then you might want also want to delete the line starts with [rubinius]
below. That would become an orphan link definiton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shyouhei This is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other translations don't have that at all. They didn't separate frequently-updated from less-updated.
This isn't entirely true, see:
www.ruby-lang.org/en/about/index.md
Line 189 in eb6223c
* [Rubinius][rubinius] is ‘Ruby written in Ruby’. Built on top of LLVM, |
and:
www.ruby-lang.org/ko/about/index.md
Line 149 in eb6223c
* [Rubinius][rubinius]는 ‘Ruby로 쓰인 Ruby’입니다. LLVM 위에 구축되어, |
Can you apply changes of |
d57ef3f
to
40946a9
Compare
@yous I'm not sure who you are asking there, but no, I'm not the one to update the Korean FAQ version. Someone else will need to do that. |
Co-authored-by: Chayoung You <yousbe@gmail.com>
This PR is a lesson on why in-repo translations are not a good idea. Let's just fix the english version and let other people open PRs to fix the other languages. |
BeOS, MS-DOS, and OS/2 haven't been supported by Ruby for a while.
IronRuby and MagLev are listed under "Discontinued" at https://github.com/planetruby/awesome-rubies
IronRuby last release was March 2011. Repo archived. (Only IronPython still seems to be alive.)
MagLev last release was October 2011.
Cardinal last commit was August 2013 (and last Parrot release in Feb. 2016).