PTY.swawn without using bash and stty #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
swawn_without_bash_stty
branch
from
f766616
to
29c903d
Compare
st0012
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessarily using
bashto run command seems to make a zombie process sometimes.Process.killcan't stop that process andProcess.waitpid(pid)waits forever. I don't know why.PTY.spawn(command); pty_output.winsize = [h, w]is enough.It is better to set winsize BEFORE process spawns (this pull request sets winsize AFTER spawn) but it looks working, it's simple, and it solves a problem.
How to reproduce
start_terminal(*args, wait: 0.001)wait: 0.0001I have no idea why it is reproducible only with very short wait time.