Added species to default pet tasks and handled related code #798

atbalaji · 2024-06-02T11:17:57Z

🔗 Issue

#709

✍️ Description

Added species related filtering to default pet tasks

📷 Screenshots/Demos

jmilljr24

@atbalaji Thanks for working on this!! Just a couple of things. Let me know your thoughts/concerns.

app/models/default_pet_task.rb

app/views/organizations/staff/default_pet_tasks/index.html.erb

jmilljr24 · 2024-06-26T23:40:38Z

@atbalaji just checking in. Not sure if you saw the feedback from @kasugaijin .

kasugaijin · 2024-07-03T01:00:00Z

@atbalaji how's this going?

atbalaji · 2024-07-05T23:20:08Z

Hi ,addressed the comments. Had some conflicts after pulling. Will work on those and tests and push within tmr

kasugaijin · 2024-07-06T02:46:02Z

Sounds good @atbalaji

atbalaji · 2024-07-08T03:42:15Z

Current update: Updated failed tests. But facing issue with a page which worked before addressing comments correctly. New error. Investigating it

atbalaji · 2024-07-12T08:55:54Z

I have updated the issue reason as reply to the earlier comments. Pls check it out.

jmilljr24 · 2024-07-12T10:11:13Z

I have updated the issue reason as reply to the earlier comments. Pls check it out.

~~@atbalaji Can you push up your changes so I can take a look on my local machine?~~
See comment above

* sets dev and test env I18n error config to raise translation missing * Fixes all missed translation errors: - Adds missing translations to corresponding en.yml - Fixes wrong look ups of translations

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Add Adopters link for adopters index * Define adopters in breadcrumbs config * Create route for adopters index * Create adopters controller with index action * Create adopters index view * Standard rb fix * Add translations for both adopters and fosterers views

* rubyforgood#753 WIP: Add fosters tab in pet show * rubyforgood#753 Lessen DB query for matches and fosters * rubyforgood#753 WIP: Make fosters responsive Clean up unused files * rubyforgood#753 Redirect to requesting page after foster delete * rubyforgood#753 Add translations to pet show fosters tab * rubyforgood#753 Code housekeeping * Fosters table alignment --------- Co-authored-by: Meghan Gutshall <meghan.gutshall@gmail.com>

* * Add Adopters link for adopters index * Define adopters in breadcrumbs config * Create route for adopters index * Create adopters controller with index action * Create adopters index view * Standard rb fix * Add translations for both adopters and fosterers views * rubyforgood#753 WIP: Add fosters tab in pet show * rubyforgood#753 Lessen DB query for matches and fosters * rubyforgood#753 WIP: Make fosters responsive Clean up unused files * rubyforgood#753 Redirect to requesting page after foster delete * rubyforgood#753 Add translations to pet show fosters tab * rubyforgood#753 Code housekeeping * Fosters table alignment --------- Co-authored-by: Meghan Gutshall <meghan.gutshall@gmail.com> * Update counter working Clean up --------- Co-authored-by: Jade Stewart <114014697+jadekstewart3@users.noreply.github.com> Co-authored-by: Meghan Gutshall <meghan.gutshall@gmail.com>

* sets dev and test env I18n error config to raise translation missing * Fixes all missed translation errors: - Adds missing translations to corresponding en.yml - Fixes wrong look ups of translations * adds lookup localization to organizations/, organizations/adopter_fosterer * Add lookup localization to organizations/staff and add missing translations * solves missing translations views errors

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Ken Maeshima <81536479+mononoken@users.noreply.github.com>

* Fix tests arguments order * fix final tests * fix final tests --------- Co-authored-by: Cairo Calleros <cairocalleros@Cairos-MBP.lan>

Bumps [faker](https://github.com/faker-ruby/faker) from 3.3.1 to 3.4.1. - [Release notes](https://github.com/faker-ruby/faker/releases) - [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md) - [Commits](faker-ruby/faker@v3.3.1...v3.4.1) --- updated-dependencies: - dependency-name: faker dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ken Maeshima <81536479+mononoken@users.noreply.github.com>

Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.8.8 to 0.8.9. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.8.8...v0.8.9) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ken Maeshima <81536479+mononoken@users.noreply.github.com>

Bumps [rails](https://github.com/rails/rails) from 7.1.3.3 to 7.1.3.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.1.3.3...v7.1.3.4) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ken Maeshima <81536479+mononoken@users.noreply.github.com>

Bumps [pagy](https://github.com/ddnexus/pagy) from 8.2.0 to 8.4.4. - [Release notes](https://github.com/ddnexus/pagy/releases) - [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md) - [Commits](ddnexus/pagy@8.2.0...8.4.4) --- updated-dependencies: - dependency-name: pagy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ken Maeshima <81536479+mononoken@users.noreply.github.com>

…follow

* replace all occurances of page text with custom page * fix unintended changes to migration files * change missed instances of PageText * change view folder name to custom pages * nested module/classes for custom pages controller * updated files that got missed for custom page change * ran linter

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Justin <16829344+jmilljr24@users.noreply.github.com>

…ion (rubyforgood#864) * Added module custom_form for Form and Question Controller and Views * Fix test cases for custom_form module for Form and Question * Nested modules * Modularize Form model and its related test cases * Modularize Question Module with CustomForm * Lint Fix * Fix seed file * Modulaize Question policy code and fix link in question form

* create: form submission model with test * add: foreign key for the has many relationship between form submission and submitted answer models * create: foreign key for has many relationship between form submission and adopter applications - create form_submission factory - add associations context block in adopter_application test * update: all instances of adopter_application requiring form_submission validation * update: adopter_application factory bot association to account for form_submission model * update: alta/baja adopter_application seed block to have a form_submission to belong to * change: belongs_to to acts_as_tenant for organization scope * update: schema preview for adopter application * update: seeds files to account for form_submission model * add: has_one association for form_submission * update form_submission test * chore: clean up * migrate database * remove: all page_text occurrences this was changed to custom_page * add: FormSubmission documentation These comments give context to what the FormSubmission class does * run: rails standard:fix

kasugaijin · 2024-07-17T22:58:17Z

@atbalaji FYI you might want to rebase and force push to get rid of all of the past commit history. This makes reviewing really hard!

jmilljr24 · 2024-07-17T23:29:09Z

@atbalaji should be good to go for adding tests as well. Thanks for the changes!!

atbalaji · 2024-07-19T03:06:09Z

Sorry for the trouble @kasugaijin and @jmilljr24 . During rebase some mishap happened due to a single commit unexpectedly which caused this. Also I have risen a new PR with a different branch name using merging for the clarity of reviewing. I am traveling for next 3 days. So i won't be available for next 3 days. I have updated failed tests. Regarding addition of new tests, pls assign it to someone in case you need it earlier. Sorry for the inconvenience.

kasugaijin · 2024-07-19T03:24:35Z

@atbalaji thank you…no sweat…it happens! No rush to get this across the line either. Don’t want you to feel pressured to get stuff in.

jmilljr24 · 2024-07-19T12:27:44Z

Opened in new PR #879

atbalaji added 2 commits May 29, 2024 16:28

Added species to default pet tasks and handled related code

25675fe

Merge branch 'main' into 709_default_pet_tasks

1db9204

jmilljr24 requested changes Jun 4, 2024

View reviewed changes

mononoken linked an issue Jun 11, 2024 that may be closed by this pull request

Default Pet Tasks: tasks should be assigned to a general category, or a species #709

Open

wandergithub and others added 19 commits July 17, 2024 21:22

737 add missing translations (rubyforgood#789)

96ef42e

* sets dev and test env I18n error config to raise translation missing * Fixes all missed translation errors: - Adds missing translations to corresponding en.yml - Fixes wrong look ups of translations

fix translations path (rubyforgood#803)

b4ef3dc

docs: add Naraveni as a contributor for code (rubyforgood#809)

0df17cd

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

disable toggle (rubyforgood#805)

6947ea0

751-Add-Foster-Email-Flow (rubyforgood#799)

8349558

744 fix test orders (rubyforgood#777)

e80c8bc

* Fix tests arguments order * fix final tests * fix final tests --------- Co-authored-by: Cairo Calleros <cairocalleros@Cairos-MBP.lan>

mononoken and others added 24 commits July 17, 2024 21:23

Replace pet_card_bigger partial with CardComponent

bde2a5c

Add badge slot to CardComponent

4984770

Replace pet_card partial with CardComponent

7b58ed8

Remove avatarable_form partial since it is used in only two locations

c33967f

Remove nice_partials

442aa7a

Replace like_button partial with LikeButtonComponent

d0117ed

Remove comment

ed74912

Move logic around and add comments to make AvatarComponent easier to …

557a66a

…follow

Add yard docs to CardComponent

6f58cd9

Add dry-initializer and dry-types to ApplicationComponent

1ff021c

Implement dry gems in CardComponent to enforce a hash schema

c05ca75

Add yard doc attributes to CardComponent with dry-initializer

48edc2e

Inline CardComponent option defaults with dry-initializer defaults

f2dffdd

Add custom ImageTagSource type

2cafcba

Create and implement BadgeComponent

bbddab1

Refactor AvatarComponent to use dry-initializer

ee5bbdb

Refactor fetching likes to direct lookups to remove n*m queries

ee33dee

fix migration naming errors

af0b427

remove copy link on pet table (rubyforgood#865)

794b65b

Addressed comments in PR and updated tests

7a8a3b7

jmilljr24 closed this Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added species to default pet tasks and handled related code #798

Added species to default pet tasks and handled related code #798

atbalaji commented Jun 2, 2024

jmilljr24 left a comment

jmilljr24 commented Jun 26, 2024

kasugaijin commented Jul 3, 2024

atbalaji commented Jul 5, 2024

kasugaijin commented Jul 6, 2024

atbalaji commented Jul 8, 2024

atbalaji commented Jul 12, 2024

jmilljr24 commented Jul 12, 2024 •

edited

Loading

kasugaijin commented Jul 17, 2024

jmilljr24 commented Jul 17, 2024

atbalaji commented Jul 19, 2024

kasugaijin commented Jul 19, 2024

jmilljr24 commented Jul 19, 2024

Added species to default pet tasks and handled related code #798

Added species to default pet tasks and handled related code #798

Conversation

atbalaji commented Jun 2, 2024

🔗 Issue

✍️ Description

📷 Screenshots/Demos

jmilljr24 left a comment

Choose a reason for hiding this comment

jmilljr24 commented Jun 26, 2024

kasugaijin commented Jul 3, 2024

atbalaji commented Jul 5, 2024

kasugaijin commented Jul 6, 2024

atbalaji commented Jul 8, 2024

atbalaji commented Jul 12, 2024

jmilljr24 commented Jul 12, 2024 • edited Loading

kasugaijin commented Jul 17, 2024

jmilljr24 commented Jul 17, 2024

atbalaji commented Jul 19, 2024

kasugaijin commented Jul 19, 2024

jmilljr24 commented Jul 19, 2024

jmilljr24 commented Jul 12, 2024 •

edited

Loading