Skip to content

Fix usage of id param in retrieve_customer #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swerner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix usage of id param in retrieve_customer #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/controllers/nocheckout/stripe/checkout_sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ def concat_unescaped_stripe_checkout_session_id(url)
# Retrives a customer from Stripe and returns a nil if the customer does not exist (instead)
# of raising an exception, because this is not exceptional).
def retrieve_customer(id:)
return nil if customer_id.blank?
return nil if id.blank?

begin
Stripe::Customer.retrieve(String(customer_id))
Stripe::Customer.retrieve(String(id))
# Blurg ... wish Stripe just returned a response object that's not an exception.
rescue Stripe::InvalidRequestError => e
case e.response.data
Expand Down