Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 7.2 #563

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add support for Rails 7.2 #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8abe3a2
Add support for Rails 7.2
andrewhampton Aug 12, 2024
257e8cb
Remove Rails 7.2 changelog entry
andrewhampton Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
rails: ["~> 7.1.0", "~> 7.0.0", "~> 6.1.0", "~> 6.0.0"]
rails: ["~> 7.2.0", "~> 7.1.0", "~> 7.0.0", "~> 6.1.0", "~> 6.0.0"]
ruby: ["3.2.2", "3.1.4", "3.0.6", "2.7.8"]
include:
- ruby: 3.2
Expand All @@ -39,6 +39,12 @@ jobs:
rails: '~> 5.2.0'
- ruby: 2.5
rails: '~> 5.1.0'
exclude:
# Rails 7.2.0 requires Ruby 3.1.0 or later
- ruby: "3.0.6"
rails: "~> 7.2.0"
- ruby: "2.7.8"
rails: "~> 7.2.0"
#os: ubuntu-latest
#arch: x64

Expand Down
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

## 2.6.4 - July 20, 2024

Add support for [Rails 7.2](https://github.com/rails/rails/releases/tag/v7.2.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 3 PRs listed below was about supporting changes in 7.2, thus that title here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 2.6.4 didn't actually support 7.2. That combined with seeing this comment made me think this line was added by mistake. So I removed it as part of this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, I should have been more clear about it. I could not bump the version until it was officially released. but those were preliminary fix that was shown to be required for those using the pre-release.


* [#554](https://github.com/rubysherpas/paranoia/pull/554) Support prebuilt counter cache association list (#554)
[Joé Dupuis](https://github.com/JoeDupuis)
* [#551](https://github.com/rubysherpas/paranoia/pull/551) Fix: restore has_one with scope (#551)
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sqlite = ENV['SQLITE_VERSION']
if sqlite
gem 'sqlite3', sqlite, platforms: [:ruby]
else
gem 'sqlite3', platforms: [:ruby]
gem 'sqlite3', '~> 1.4', platforms: [:ruby]
end

platforms :jruby do
Expand Down
2 changes: 1 addition & 1 deletion paranoia.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.5'

s.add_dependency 'activerecord', '>= 5.1', '< 7.2'
s.add_dependency 'activerecord', '>= 5.1', '< 8.0'

s.add_development_dependency "bundler", ">= 1.0.0"
s.add_development_dependency "rake"
Expand Down