Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen faraday-gzip to a version that can use > zlib-2.1.1 #613

Merged

Conversation

technicalpickles
Copy link

I was looking to update our app from using zlib 2.1.1 to the latest zlib-3.1.1, but bundler wasn't able to update it. I tracked down the dependency chain to:

  • faraday-gzip-1.0.1 depends on zlib ~> 2.1, which resolves to zlib-2.1.1
  • quickbook-ruby depends on faraday-gzip ~> 1.0 which resolves to faraday-gzip-1.0.1

This PR tries to loosen the dependency to >= 1.0. I'm open to other variations that would allow faraday-gzip-2 though.

@kevGalway
Copy link

We have the same problem so eager for solution to this too.

We are on latest version of ruby (3.3.3) meaning zlib 3.1.1 is a standard/default gem (https://stdgems.org/zlib/)

to update faraday to 2.x we need to update quickbooks-ruby to 2.x
quickbooks-ruby2.x depends on faraday-gzip (> 0.1) to faraday-gzip (> 1.0)
faraday-gzip before 2.0 depends on zlib 2.x and only starting to use zlib 3.x from version 2.0.0

@technicalpickles purposed solutions should work for us.

@ruckus ruckus merged commit 34f5330 into ruckus:2-stable Jul 3, 2024
18 checks passed
@ruckus
Copy link
Owner

ruckus commented Jul 3, 2024

Thank you @technicalpickles . Makes sense.

@technicalpickles technicalpickles deleted the loosen-faraday-gzip-for-newer-zlib branch July 22, 2024 18:42
@technicalpickles
Copy link
Author

@ruckus Thank you! Any chance of getting a release with this out as well?

@ruckus
Copy link
Owner

ruckus commented Jul 24, 2024

Hi @technicalpickles I just released 2.0.4 with your PR. Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants