Skip to content

chore: log error when rudder_resource_id not present in alert #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

chore: log error when rudder_resource_id not present in alert #168

merged 2 commits into from
Aug 30, 2024

Conversation

itsmihir
Copy link

@itsmihir itsmihir commented Aug 27, 2024 •
edited
Loading

Description of the change

Resolve OBS-612

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@itsmihir itsmihir changed the base branch from master to develop August 27, 2024 17:03
@itsmihir itsmihir closed this Aug 27, 2024
@itsmihir itsmihir reopened this Aug 27, 2024
@itsmihir itsmihir merged commit 900278d into develop Aug 30, 2024
6 checks passed
@itsmihir itsmihir deleted the chore.log-error-resource-type-missing branch August 30, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satishrudderstack satishrudderstack satishrudderstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsmihir @satishrudderstack