Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rudderpreferencemanager class #463

Open
wants to merge 21 commits into
base: feat/android
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3f1b6da
feat: create SharedPrefs file
ChryssaAliferi Jul 17, 2024
a6941b5
feat: create SharedPrefsRepository interface
ChryssaAliferi Jul 17, 2024
b706777
feat: create SharedPrefsStore implementation
ChryssaAliferi Jul 17, 2024
7e1cd93
feat: replace implementation on AndroidStorageImpl
ChryssaAliferi Jul 17, 2024
cc4f3c7
feat: permanently remove RudderPreferenceManager
ChryssaAliferi Jul 17, 2024
77a60e1
feat: minor improvements due to warnings
ChryssaAliferi Jul 17, 2024
345e09a
Merge branch 'feat/android' into feature/sdk-2150-refactor-rudderpref…
ChryssaAliferi Jul 19, 2024
bb5c3e0
feat: removes nullability from AndroidStorage properties
ChryssaAliferi Jul 19, 2024
122395e
feat: improves initial values on anonymousID and userID
ChryssaAliferi Jul 19, 2024
f1db0cd
feat: improves generateAnonymousId() method according to specs
ChryssaAliferi Jul 19, 2024
c481bb6
feat: applies changes in AnonymousIdHeaderPlugin
ChryssaAliferi Jul 19, 2024
d248138
feat: applies changes in AppInstallUpdateTrackerPlugin
ChryssaAliferi Jul 19, 2024
11b993a
feat: applies changes in ConfigurationAndroidBuilder
ChryssaAliferi Jul 19, 2024
b66eec1
feat: applies changes in ExtractStatePlugin
ChryssaAliferi Jul 19, 2024
cb213ed
feat: applies changes in FillDefaultsPlugin
ChryssaAliferi Jul 19, 2024
da7db33
feat: applies changes in ReinstatePlugin
ChryssaAliferi Jul 19, 2024
06d3f8d
feat: minor changes applied
ChryssaAliferi Jul 19, 2024
b945fed
Update android/src/main/java/com/rudderstack/android/internal/prefs/S…
ChryssaAliferi Jul 19, 2024
712901d
Update android/src/main/java/com/rudderstack/android/internal/plugins…
ChryssaAliferi Jul 19, 2024
b980143
feat: applies comments from PR
ChryssaAliferi Jul 19, 2024
0ef6d59
feat: minor correction
ChryssaAliferi Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: improves initial values on anonymousID and userID
  • Loading branch information
ChryssaAliferi committed Jul 19, 2024
commit 122395e04345b8cd654b26b8da3465d5fe84a682
Original file line number Diff line number Diff line change
@@ -301,20 +301,8 @@ class AndroidStorageImpl(
override val startupQueue: List<Message> = startupQ
override val optOutTime: Long = _optOutTime.get()
override val optInTime: Long = _optInTime.get()
override val anonymousId: String?
get() {
if (_anonymousId == null) {
_anonymousId = rudderPrefsRepo.getString(RUDDER_ANONYMOUS_ID_KEY)
}
return _anonymousId
}
override val userId: String?
get() {
if (_userId == null) {
_userId = rudderPrefsRepo.getString(RUDDER_USER_ID_KEY)
}
return _userId
}
override val anonymousId: String = rudderPrefsRepo.getString(RUDDER_ANONYMOUS_ID_KEY)
override val userId: String = rudderPrefsRepo.getString(RUDDER_USER_ID_KEY)
override val sessionId: Long = rudderPrefsRepo.getLong(RUDDER_SESSION_ID_KEY)
override val lastActiveTimestamp: Long = rudderPrefsRepo.getLong(RUDDER_SESSION_LAST_ACTIVE_TIMESTAMP_KEY)
override val advertisingId: String = rudderPrefsRepo.getString(RUDDER_ADVERTISING_ID_KEY)