Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove arguments from the public events apis which are not required #464

Open
wants to merge 21 commits into
base: feat/android
Choose a base branch
from

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Jul 18, 2024

Description

  • Removed unused arguments (like userId) from public events APIs (like Track) which are not required and also they are not in parity with v1.
  • Removed unused arguments from event DSL class e.g., removed traits field from TrackScope class.
  • Fixed indentation.
  • Fixed failing test cases.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey 1abhishekpandey requested a review from a team July 18, 2024 12:35
@1abhishekpandey 1abhishekpandey self-assigned this Jul 18, 2024
@1abhishekpandey 1abhishekpandey marked this pull request as draft July 18, 2024 12:44
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review July 18, 2024 14:21
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant