Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapping changes for aifa,andi and asid #3465

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Jun 17, 2024

What are the changes introduced in this PR?

For Android requests, Singular requires either AIFA, ASID, or ANDI, in that order of preference. All 3 can be sent if available, and our servers will discard the ANDI per Google's data policies. If AIFA is not available, ASID should be sent. If ASID is not available, ANDI should be sent. If a given device ID is not available, the respective param should be sent with an empty value (rather than null, or some other value).

We are making these changes in our Singular destination integration.

What is the related Linear task?

Resolves INT-2241

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

We are making this change as currently the integration does not send Android events to Singular that are missing the ASID property.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Jun 17, 2024
@yashasvibajpai yashasvibajpai requested a review from a team as a code owner June 17, 2024 02:18
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (3aee494) to head (34cb51d).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3465      +/-   ##
===========================================
+ Coverage    88.00%   88.02%   +0.01%     
===========================================
  Files          572      572              
  Lines        30910    30971      +61     
  Branches      7385     7407      +22     
===========================================
+ Hits         27202    27261      +59     
+ Misses        3398     3372      -26     
- Partials       310      338      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yashasvibajpai yashasvibajpai merged commit a0f5c2f into develop Jun 24, 2024
22 checks passed
@yashasvibajpai yashasvibajpai deleted the feat.singular.android.id.validation branch June 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants