Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable labels for api calls #3476

Merged
merged 24 commits into from
Jul 24, 2024
Merged

chore: enable labels for api calls #3476

merged 24 commits into from
Jul 24, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Jun 18, 2024

What are the changes introduced in this PR?

Add below labels to any API calls made from transformer

  • statusCode
  • destinationId
  • workspaceId

Metadata has been propagated for intermediate API calls(to obtain extra metadata in metrics) for below destinations have been added

  • intercom
  • mautic
  • optimizely_fullstack
  • active_campaign
  • klaviyo
  • delighted

What is the related Linear task?

Resolves INT-2152

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from sivashanmukh and a team as code owners June 18, 2024 12:31
@devops-github-rudderstack
Copy link
Contributor

utsabc
utsabc previously approved these changes Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 98.29352% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.18%. Comparing base (13dac30) to head (e4b381e).
Report is 11 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/user/transform.js 90.47% 2 Missing ⚠️
src/v0/destinations/user/utils.js 85.71% 2 Missing ⚠️
src/v0/destinations/marketo/transform.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3476      +/-   ##
===========================================
+ Coverage    88.11%   88.18%   +0.07%     
===========================================
  Files          584      590       +6     
  Lines        31496    31778     +282     
  Branches      7549     7595      +46     
===========================================
+ Hits         27754    28025     +271     
- Misses        3431     3442      +11     
  Partials       311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 force-pushed the chore.labels-int-api branch from 0e9a745 to 9a39d67 Compare June 18, 2024 13:28
@sanpj2292 sanpj2292 requested a review from utsabc June 18, 2024 13:30
utsabc
utsabc previously approved these changes Jun 18, 2024
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 requested a review from utsabc June 19, 2024 05:36
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 requested review from koladilip and removed request for chandumlg June 19, 2024 05:48
koladilip
koladilip previously approved these changes Jun 19, 2024
Sai Sankeerth and others added 2 commits June 21, 2024 15:03
* chore: enable labels for api call - 2

* chore: propagate metadata in following destinations
- canny
- clickup
- custify
- freshmarketer
- freshsales
- wootric

* chore: propagate metadata for below destinations
- monday
- profitwell
- sendgrid
- sendinblue

* chore: fix sfmc transformation test

* chore: enable labels for api calls - 3 (#3483)

* chore: enable labels for api calls - 3

* chore: propagate metadata for user destination

* chore: propagate metadata in braze

* chore: propagate metadata for api calls in hubspot

* chore: propagate metadata for labels in api calls for
- pardot
- rakuten
- snapchat_custom_audience
- the_trade_desk
- yahoo_dsp

* chore: propagate metadata in zendesk

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: propagate metadata in gainsight

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>

* chore: update canny transformation to include await keyword

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: add async for canny destination - fix eslint error

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
@sanpj2292 sanpj2292 dismissed stale reviews from ItsSudip and yashasvibajpai via de6f59f July 2, 2024 13:14
ItsSudip
ItsSudip previously approved these changes Jul 3, 2024
ItsSudip
ItsSudip previously approved these changes Jul 5, 2024
@sanpj2292 sanpj2292 self-assigned this Jul 18, 2024
Copy link

@sanpj2292 sanpj2292 merged commit 3f75b55 into develop Jul 24, 2024
17 checks passed
@sanpj2292 sanpj2292 deleted the chore.labels-int-api branch July 24, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants