Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable labels for api calls - 2 #3479

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Jun 19, 2024

What are the changes introduced in this PR?

Metadata has been propagated for intermediate API calls(to obtain extra metadata in metrics) for below destinations have been added

  • salesforce
  • sfmc
  • canny
  • clickup
  • custify
  • freshmarketer
  • freshsales
  • wootric
  • monday
  • profitwell
  • sendgrid
  • sendinblue

What is the related Linear task?

Resolves INT-2152

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners June 19, 2024 09:19
@sanpj2292 sanpj2292 requested review from utsabc and Gauravudia June 19, 2024 09:19
@sanpj2292 sanpj2292 changed the base branch from develop to chore.labels-int-api June 19, 2024 09:20
@devops-github-rudderstack
Copy link
Contributor

Sai Sankeerth added 3 commits June 19, 2024 15:23
- canny
- clickup
- custify
- freshmarketer
- freshsales
- wootric
- monday
- profitwell
- sendgrid
- sendinblue
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (ca78546) to head (cab413b).

Files Patch % Lines
src/v0/destinations/user/transform.js 90.47% 2 Missing ⚠️
src/v0/destinations/user/utils.js 85.71% 2 Missing ⚠️
src/v0/destinations/gainsight/transform.js 83.33% 1 Missing ⚠️
src/v0/destinations/marketo/transform.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           chore.labels-int-api    #3479   +/-   ##
=====================================================
  Coverage                 88.07%   88.07%           
=====================================================
  Files                       577      577           
  Lines                     31216    31231   +15     
  Branches                   7445     7446    +1     
=====================================================
+ Hits                      27492    27507   +15     
+ Misses                     3414     3386   -28     
- Partials                    310      338   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 requested review from koladilip and ItsSudip June 19, 2024 12:08
sanpj2292 and others added 3 commits June 20, 2024 12:15
* chore: enable labels for api calls - 3

* chore: propagate metadata for user destination

* chore: propagate metadata in braze

* chore: propagate metadata for api calls in hubspot

* chore: propagate metadata for labels in api calls for
- pardot
- rakuten
- snapchat_custom_audience
- the_trade_desk
- yahoo_dsp

* chore: propagate metadata in zendesk

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: propagate metadata in gainsight

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked for braze, canny, clickup, custify, freshmarketer, freshsales.

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
@sanpj2292 sanpj2292 requested a review from ItsSudip June 21, 2024 13:21
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.1% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

@sanpj2292 sanpj2292 merged commit de6f59f into chore.labels-int-api Jul 2, 2024
16 of 17 checks passed
@sanpj2292 sanpj2292 deleted the chore.labels-int-api-1 branch July 2, 2024 13:14
sanpj2292 added a commit that referenced this pull request Jul 24, 2024
* chore: enable labels for api calls

* chore: propagate metadata to api call fn in intercom dest

* chore: metadata propagation in mautic & optimizely_fullstack

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: metadata propagation in active_campaign

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: metadata propagation in delighted & klaviyo

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: add method doc to getRelativePathFromURL

* chore: add test-cases to test firing of stats based on metadata

* chore: enable labels for api calls - 2 (#3479)

* chore: enable labels for api call - 2

* chore: propagate metadata in following destinations
- canny
- clickup
- custify
- freshmarketer
- freshsales
- wootric

* chore: propagate metadata for below destinations
- monday
- profitwell
- sendgrid
- sendinblue

* chore: fix sfmc transformation test

* chore: enable labels for api calls - 3 (#3483)

* chore: enable labels for api calls - 3

* chore: propagate metadata for user destination

* chore: propagate metadata in braze

* chore: propagate metadata for api calls in hubspot

* chore: propagate metadata for labels in api calls for
- pardot
- rakuten
- snapchat_custom_audience
- the_trade_desk
- yahoo_dsp

* chore: propagate metadata in zendesk

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

* chore: propagate metadata in gainsight

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>

* chore: update canny transformation to include await keyword

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: add async for canny destination - fix eslint error

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: remove duplicate metadata key in statTags obj klaviyo

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>

---------

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants