Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove high cardinality histogram metrics #3482

Closed
wants to merge 3 commits into from

Conversation

dhawal1248
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@dhawal1248 dhawal1248 requested review from a team and sivashanmukh as code owners June 19, 2024 10:39
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (3f9bfac) to head (77e6204).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3482      +/-   ##
===========================================
+ Coverage    88.06%   88.08%   +0.01%     
===========================================
  Files          577      579       +2     
  Lines        31207    31227      +20     
  Branches      7442     7444       +2     
===========================================
+ Hits         27483    27505      +22     
+ Misses        3386     3384       -2     
  Partials       338      338              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanpj2292
sanpj2292 previously approved these changes Jun 20, 2024
Copy link

psrikanth88
psrikanth88 previously approved these changes Jun 24, 2024
@dhawal1248 dhawal1248 dismissed stale reviews from psrikanth88 and sanpj2292 via fd00bff June 28, 2024 14:08
@dhawal1248 dhawal1248 force-pushed the feature/sre-489-remove-histogram-metrics branch from fd00bff to 77e6204 Compare June 28, 2024 14:10
@dhawal1248 dhawal1248 closed this Jun 28, 2024
@dhawal1248 dhawal1248 deleted the feature/sre-489-remove-histogram-metrics branch June 28, 2024 16:24
@dhawal1248
Copy link
Contributor Author

tracked here: #3515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants