Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zoho vdmv2 #4096

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: zoho vdmv2 #4096

wants to merge 6 commits into from

Conversation

am6010
Copy link
Contributor

@am6010 am6010 commented Feb 19, 2025

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 95.30201% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.16%. Comparing base (aed87ce) to head (8a807a9).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdk/v2/destinations/zoho/transformRecordV2.js 93.93% 6 Missing ⚠️
src/cdk/v2/destinations/zoho/transformRecord.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4096      +/-   ##
===========================================
+ Coverage    91.13%   91.16%   +0.03%     
===========================================
  Files          629      630       +1     
  Lines        32840    33023     +183     
  Branches      7794     7826      +32     
===========================================
+ Hits         29928    30105     +177     
+ Misses        2696     2670      -26     
- Partials       216      248      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@am6010 am6010 force-pushed the feat.int-3217-zoho-vdmv2 branch from b169c82 to f268a28 Compare February 19, 2025 15:42
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@am6010 am6010 force-pushed the feat.int-3217-zoho-vdmv2 branch from ec26348 to 8e117a4 Compare February 20, 2025 06:31
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@am6010 am6010 marked this pull request as ready for review February 20, 2025 08:58
@am6010 am6010 requested review from a team and sivashanmukh as code owners February 20, 2025 08:58
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@am6010 am6010 force-pushed the feat.int-3217-zoho-vdmv2 branch from 9bbe1bc to 75133ec Compare February 21, 2025 15:13
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants