Add list passwords command #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochen42
commented
Jun 29, 2023
jochen42
commented
- removed the local copy of proto-files
- added proto-files via go.mod
- add the password list command
rudeigerc
reviewed
Jul 1, 2023
| } | ||
|
|
||
| func listPasswordsAction(c *cli.Context) error { | ||
|
|
There was a problem hiding this comment.
Empty line(s) could be omitted.
rudeigerc
reviewed
Jul 1, 2023
| @@ -35,4 +29,4 @@ build: generate fmt vet ## Build manager binary. | |||
|
|
|||
| .PHONY: clean | |||
| clean: | |||
| @rm -rf bin/ pkg/protos/*.pb.go | |||
| @rm -rf bin/ | |||
There was a problem hiding this comment.
Since the build command depends on generate previously, it should also be modified.
rudeigerc
requested changes
Jul 1, 2023
There was a problem hiding this comment.
Hi, thanks for the PR! To be honest, I haven't worked on dexctl for quite a while, so I quite appreciate that someone has made a pull request. I have some tasks related to Dex again currently, so I may continue to pay attention to this repository.
Here are some comments for the PR, please have a look at it. Once again, thanks a lot :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.