Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop,ci: Adding AppImage support #12402

Closed
wants to merge 36 commits into from

Conversation

kevin-wijnen
Copy link

Adding AppImage support through the use of Cargo AppImage in the CI through GitHub Actions.

For more details, see #12401.

Current issues:

  • Cargo.toml of the desktop package would not be able to used, despite modifications.

@kevin-wijnen kevin-wijnen changed the title desktop/ci: Adding AppImage support desktop, ci: Adding AppImage support Jul 29, 2023
@kevin-wijnen kevin-wijnen changed the title desktop, ci: Adding AppImage support desktop,ci: Adding AppImage support Jul 29, 2023
@n0samu
Copy link
Member

n0samu commented Jul 30, 2023

Thank you for your work on this! I'm not a Linux user, but I know it is a goal of the project to offer AppImage builds. Can you tell us what problem you ran into with the Cargo.toml?

Using an empty `src` directory, to mitigate issue 16 despite being resolved prior; StratusFearMe21/cargo-appimage#16
@kevin-wijnen
Copy link
Author

kevin-wijnen commented Jul 30, 2023

Thank you all for even bringing this project to life!

Can you tell us what problem you ran into with the Cargo.toml?

During the cargo appimage process, it simply gives a generic error of Cannot load metadata from Cargo.toml. This seems to happen after building the crate itself successfully. I am currently unsure whether it is a Rust generic issue, or one with Cargo AppImage itself as I did not find any similar open issues at Cargo AppImage's repository.

The only similar issue that has been previously resolved, is #16, which details it has something to do with actual locating it because of a differing file location.

I'm currently running another run with an empty src directory, to see if that temporary workaround does work.

@kevin-wijnen
Copy link
Author

Even with the empty src folder workaround, it does not seem to function. The specific issue lies with Cargo AppImage, as it does a cargo build before doing its own process to package it. Yet for said own process, it simply cannot find the right Cargo.toml, despite using it prior for building the Crate to begin with.

Already issued a report at #27 at their repository. I will try to find a different method of producing working AppImages, if Cargo AppImage will continue to fail.

@kevin-wijnen
Copy link
Author

kevin-wijnen commented Mar 8, 2024

Sorry for the late response:

I recently took another look at trying to get AppImages packed for this project. Yet my (personal) motivation dwindled since recent AppImage versions (personally tested it with the nightly released on Fri Jan 26th 2024) do run on my Steam Deck.

So with the lack of personal motivation and knowledge about Rust, I will close this Pull Request for now, hopefully someone else will continue the work.

@n0samu Any pointers re: AppImage support are found here, #12401 and in #12633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants