chore: Move AvmString code into a new crate #21629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-other
|
The idea of separating avm string to its own crate sounds good, but I'd say we 100% have to do benchmarks and make sure it doesn't affect performance negatively. |
Lord-McSweeney
force-pushed
the
avmstring-crate
branch
from
71ce3dd to
b2d8c7c
Compare
|
I don't see any performance impact from this change (on microbenchmarks for string indexing and concatenation) and I see a ~2 second speedup in recompiling core, so I think this is okay on the performance side. |
Lord-McSweeney
added
the
waiting-on-review
Lord-McSweeney
force-pushed
the
avmstring-crate
branch
from
b2d8c7c to
491d087
Compare
Lord-McSweeney
changed the title
Lord-McSweeney
force-pushed
the
avmstring-crate
branch
from
491d087 to
71c1804
Compare
moulins
reviewed
Sep 12, 2025
| pub use common::CommonStrings; | ||
| pub use context::{HasStringContext, StringContext}; | ||
| pub use interner::{AvmAtom, AvmStringInterner}; | ||
| use ruffle_wstr::{from_utf8, WStr, WString}; |
There was a problem hiding this comment.
I'd keep the other reexports (now from ruffle_common::avm_string), to avoid having to update the use statements everywhere else.
In the future, we can move other types shared across the AVMs and core player to this crate
Lord-McSweeney
force-pushed
the
avmstring-crate
branch
from
71c1804 to
0b379ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make separating AVM2 from core slightly easier in the future, if we ever do it. This also reduces compile times slightly, especially when re-building after modifying
corecode.The only downside of this that I can see is that without LTO, some functions from
avm_stringmight not get inlined incore. However, those functions don't seem to be very hot, so this is probably fine.