render: Support rendering filters in BitmapData.draw
#21672
+148
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-rendering
|
Note that this PR fixes #12202 in terms of rendering filters, but breaks it in terms of scaling/positioning the bitmap. I suspect this is an unrelated CAB bug, but I want to make sure (or even fix it) before merging this one. |
|
Also, I have no idea what's up with |
kjarosh
added
the
waiting-on-author
|
This should also fix #15107 |
kjarosh
force-pushed
the
bitmapdata-draw-cab
branch
from
52fc5fe to
b2bc502
Compare
kjarosh
added
waiting-on-review
|
will this PR resolve #21509 ? |
|
This actually breaks |
kjarosh
added
waiting-on-author
This patch adds support for CAB rendering in `BitmapData.draw` which fixes missing filters. Currently it supports CAB rendering only with the same quality due to how CAB is being implemented. In the future we should also support CAB rendering with different qualities.
kjarosh
force-pushed
the
bitmapdata-draw-cab
branch
from
b2bc502 to
c08bd27
Compare
|
Constrained CAB rendering for the same quality only, this should fix the majority of content. We can implement CAB rendering for different qualities in the future. |
kjarosh
added
waiting-on-review
Dinnerbone
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bmd.draw()(BitmapData) #15107This patch adds support for CAB rendering in
BitmapData.drawwhich fixes missing filters.