Skip to content

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 21, 2025

Let's do some random stuff and hope it works

@kjarosh kjarosh added A-build Area: Build scripts & CI T-fix Type: Bug fix (in something that's supposed to work already) labels Sep 21, 2025
@torokati44
Copy link
Member

I'm not 100% sure that secrets like these are exposed for runs done in forks (for PRs).

@Dinnerbone
Copy link
Contributor

I'm not 100% sure that secrets like these are exposed for runs done in forks (for PRs).

They aren't, this would require each fork to have that secret defined - if it did, it would give our secret to anybody.

@torokati44
Copy link
Member

@kjarosh kjarosh changed the title ci: Use RuffleBuild for posting coverage comments ci: Fix posting coverage comments Sep 21, 2025
@torokati44
Copy link
Member

There are 20k+ lines of ruffle_core::html::layout: Fallback font not found ... for ..., text will be missing logged in the coverage test 💀

@torokati44
Copy link
Member

The

permissions:
  contents: write
  pull-requests: write

part is probably necessary? (present in the SO answer and the linked workflow as well)

@kjarosh kjarosh marked this pull request as draft September 21, 2025 16:25
@torokati44
Copy link
Member

torokati44 commented Sep 21, 2025

My current guess is that in the egui repo it works because the workflow that posts the comment is not triggered on the PR itself, but on the completion of such a workflow run.

@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Sep 21, 2025

Let's do some random stuff and hope it works

Me when I'm programming:

@danielhjacobs
Copy link
Contributor

Per https://github.com/thollander/actions-comment-pull-request?tab=readme-ov-file#permissions

Note that, if the PR comes from a fork, it will have only read permission despite the permissions given in the action for the pull_request event. In this case, you may use the pull_request_target event. With this event, permissions can be given without issue (the difference is that it will execute the action from the target branch and not from the origin PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build Area: Build scripts & CI T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants