-
-
Notifications
You must be signed in to change notification settings - Fork 922
ci: Fix posting coverage comments #21724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I'm not 100% sure that secrets like these are exposed for runs done in forks (for PRs). |
They aren't, this would require each fork to have that secret defined - if it did, it would give our secret to anybody. |
f441a75
to
8f522f9
Compare
8f522f9
to
93bcb8f
Compare
There are 20k+ lines of |
The
part is probably necessary? (present in the SO answer and the linked workflow as well) |
93bcb8f
to
81bb0fa
Compare
81bb0fa
to
31b4b71
Compare
My current guess is that in the |
Me when I'm programming: |
Per https://github.com/thollander/actions-comment-pull-request?tab=readme-ov-file#permissions
|
Let's do some random stuff and hope it works