web: Properly classify web fonts as italic #21900
Conversation
Fonts can have style regular and non-zero italic angle. This however should not classify them as italic, even if they might look like it visually. This makes it behave the same way as on desktop.
kjarosh
added
A-web
|
Also filed an issue to ttf parser about it: harfbuzz/ttf-parser#202 |
| is_italic: face.is_italic(), | ||
| // Note: do not use is_italic() here, as we don't care about italic_angle | ||
| is_italic: face.style() != ttf_parser::Style::Normal, |
There was a problem hiding this comment.
I had to look up ttf_parser::Style to see what the other "non-normal" styles are. As in - is "bold" in there, etc.
Just a nit of course, but do you think that checking for the (currently existing) other two variants explicitly would be nicer...?
There was a problem hiding this comment.
What would be the purpose?
There was a problem hiding this comment.
Being more self-explanatory. Not relying on other variants not mentioned there. Not prompting the reader to look up what those variants are. And again, I don't insist on this - just wanted to note that it wasn't immediately obvious (at least for me, before looking up the docs) that this is correct.
3 participants
Fonts can have style regular and non-zero italic angle. This however should not classify them as italic, even if they might look like it visually.
This makes it behave the same way as on desktop.