New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom currency symbols #590

Merged

sanchit3008 merged 3 commits into master from 589-set-default-currency-symbol-in-settings

Aug 31, 2024

Collaborator

sanchit3008 commented Aug 31, 2024 •

edited

Loading

Resolves #589

Adds a new optional currency prop for the Workbook - expects a currency symbol. Supports all major currency symbols. Default value if not specified is ¥. Will throw error on usage if invalid symbol is specified.
Dynamic SVG for the currency icon in toolbar for $, €, £, ₹ and ¥. Fallback for others is ¥. More can be added on request.
Dynamic text in formatting dropdown menu based on currency prop. Fallback is ¥.

sanchit3008 added 3 commits

August 31, 2024 07:57


          feat: add support for custom currency symbols

2bf3f13


          fix: make currency prop optional

fdebe93


          fix: set default currency value

64ff1bd

sanchit3008 linked an issue

that may be closed by this pull request

Set default currency symbol in settings #589

Closed

sanchit3008 merged commit 202aa69 into master

2 checks passed

sanchit3008 deleted the 589-set-default-currency-symbol-in-settings branch

August 31, 2024 08:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet