Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: batch API, calculateFormula API improvements #658

Merged
merged 1 commit into from
Jan 9, 2025
Merged

added: batch API, calculateFormula API improvements #658

merged 1 commit into from
Jan 9, 2025

Conversation

Corbe30
Copy link
Contributor

@Corbe30 Corbe30 commented Jan 9, 2025 •
edited
Loading

  • This PR will enable single undo/redo for multiple API calls
  • batchCallApis does not call the exported APIs, instead calls those internal APIs which the exported APIs calls. So the name of export and internal APIs must be same. For example - in this PR, I had to change name of calculateSheetFormula to calculateFormula, so that it's obvious to users what name to pass in argument. Hence, APIs like addPresences and removePresences are not be supported by batchCallApis()

@sanchit3008 sanchit3008 merged commit ebc72ef into ruilisi:master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchit3008 sanchit3008 sanchit3008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corbe30 @sanchit3008