Improve client and deprecate useless features#149
Merged
ruimarinho merged 4 commits intomasterfrom Jan 23, 2025
Merged
Conversation
91b24cd to
eb1054b
Compare
4bb315a to
73ccd8a
Compare
7b80b52 to
36cd02e
Compare
jpuh
reviewed
Jan 8, 2025
36cd02e to
6bdbf29
Compare
ruimarinho
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the codebase, focusing on updating dependencies, removing deprecated features, and adding support for new Bitcoin Core methods. The most important changes include updating the Node.js versions in the CI configuration, modifying the
README.mdto reflect new usage instructions, and updating the Docker and package configurations to support the latest Bitcoin Core versions.Updates and Improvements:
CI Configuration:
.github/workflows/tests.yaml)Documentation:
README.mdby removing outdated SSL/TLS connection examples and updating the usage instructions to reflect the new default values and removed options. (README.md) [1] [2] [3] [4]Docker Configuration:
docker-compose.yml) [1] [2]Package Configuration:
dependenciesscript inpackage.jsonto reflect these changes. (package.json)Codebase Simplification:
Clientclass, simplifying the connection setup process. (src/index.js) [1] [2] [3] [4]createWalletDescriptor,descriptorProcessPsbt,enumerateSigners,getAddrManInfo,getBlockFromPeer,getChainStates,getHdKeys,getPrioritisedTransactions,getTxSpendingPrevOut,importMempool,loadTxOutSet,migrateWallet,newKeyPool,psbtBumpFee,scanBlocks,scanTxOutSet,send, andsendAll. (src/methods.js) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]