Skip to content

Add Extract V2 e2e tests#59

Closed
eli-stewart wants to merge 3 commits intorelease-please--branches--main--changes--nextfrom
eli/extract-e2e-tests
Closed

Add Extract V2 e2e tests#59
eli-stewart wants to merge 3 commits intorelease-please--branches--main--changes--nextfrom
eli/extract-e2e-tests

Conversation

@eli-stewart
Copy link

Summary

  • Adds end-to-end tests for the Extract V2 resource (tests/e2e/test_extract_e2e.py)
  • Tests create, get, wait_for_completion, run, and list against the real API
  • Both sync (TestExtractE2ESync) and async (TestExtractE2EAsync) — 7 tests total
  • Skipped when LLAMA_CLOUD_API_KEY is not set (so CI won't break)

Test plan

  • All 7 tests pass locally with a real API key (64s total)
  • Add LLAMA_CLOUD_API_KEY as a GitHub Actions secret to run in CI

🤖 Generated with Claude Code

@eli-stewart eli-stewart marked this pull request as ready for review March 11, 2026 02:11
eli-stewart and others added 2 commits March 10, 2026 19:17
Tests create, get, wait_for_completion, run, and list against the real
LlamaCloud API. Requires LLAMA_CLOUD_API_KEY env var — skipped otherwise.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@eli-stewart eli-stewart force-pushed the eli/extract-e2e-tests branch from e93adfb to c1342fe Compare March 11, 2026 02:18
@eli-stewart eli-stewart changed the base branch from next to eli/extract-run-method March 11, 2026 02:18
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@logan-markewich
Copy link
Contributor

looks like the e2e tests fail. I thiiiink this is because ./scripts/test injects a dummy server? I could be wrong. We likely need e2e tests to be their own github action for this to work

@logan-markewich logan-markewich changed the base branch from eli/extract-run-method to release-please--branches--main--changes--next March 11, 2026 03:54
@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next branch 9 times, most recently from 3e23687 to 26cc453 Compare March 17, 2026 20:00
@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next branch 2 times, most recently from 4bd9b12 to 0b9d703 Compare March 20, 2026 21:59
@logan-markewich
Copy link
Contributor

going to close this. E2E is tricky/slow to run in CICD, and locally the examples folder should be used for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants