This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add SingleStoreReader #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjliu
reviewed
Jul 19, 2023
Disiok
reviewed
Jul 21, 2023
llama_hub/singlestore/base.py
Outdated
| from llama_index.readers.schema.base import Document | ||
| from llama_index import download_loader, ListIndex | ||
|
|
||
| import pymysql |
There was a problem hiding this comment.
Please do the imports from within the class and raise import error with appropriate error messages.
For example: https://github.com/emptycrown/llama-hub/blob/main/llama_hub/couchdb/base.py
Disiok
suggested changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads documents from a singlestore table that has been populated with text and embedding columns
Fixed the poetry.lock issue