Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Ionic shopping tool #915

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

stewartjarod
Copy link
Contributor

@stewartjarod stewartjarod commented Jan 31, 2024

Description

Ionic is a shopping assistant tool for llms. I've added the tool, which depends on our Ionic API SDK library.

While there, I updated the typing packages.

Note: I had issues with running tests locally, even on main, so I'm not entirely sure if this is good to merge without a CI/CD step for tests.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jerryjliu
Copy link
Collaborator

out of curiosity @stewartjarod what were the issues you ran into in running tests?

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a cool idea!

to make sure, the main capability the API offers is query right? not actually being able to make a purchase decision yet?

@@ -27,8 +27,8 @@ pytest = "7.2.1"
pytest-dotenv = "0.5.2"
pytest_httpserver = "1.0.8"
pytest-mock = "3.11.1"
typing-inspect = "0.8.0"
typing_extensions = "^4.5.0"
typing-inspect = "0.9.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the understanding with these Python types that it is good to keep them up to date and that they are entirely backward compatible. I could be wrong! I come from mostly a TS background and try to use types for everything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can roll this back if it will cause issues

@stewartjarod
Copy link
Contributor Author

I wasn't able to get the async tests to pass.

Right, at this time we provide a query for products and recommendations. Looking to expand from there. 😀

@stewartjarod
Copy link
Contributor Author

Ah, that's a weird failure. While I'm figuring this out, @jerryjliu do you want me to revert the package update for typings?

@stewartjarod
Copy link
Contributor Author

Tests should pass now 👍

@stewartjarod
Copy link
Contributor Author

Ah, that's a new one. Type responses like that must not be supported in 3.8. Sorry for the issues here with tests. Adding future annotations seemed to do the trick here.

@stewartjarod
Copy link
Contributor Author

Let me know if there is anything else I can do here! Thank you for your support.

@jerryjliu jerryjliu merged commit b066238 into run-llama:main Feb 7, 2024
3 checks passed
@stewartjarod stewartjarod deleted the IonicShoppingTool branch February 7, 2024 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants