Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add retries arg to github reader #954

Closed
wants to merge 1 commit into from
Closed

Add retries arg to github reader #954

wants to merge 1 commit into from

Conversation

rwood-97
Copy link
Contributor

Description

This implements #953

Type of Change

  • Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@rwood-97
Copy link
Contributor Author

Going to do this on llama-index repo

@rwood-97 rwood-97 closed this Feb 16, 2024
@rwood-97 rwood-97 reopened this Feb 16, 2024
@rwood-97
Copy link
Contributor Author

I'm back here

@jerryjliu
Copy link
Collaborator

@rwood-97 was there an issue with porting the change over to the main llama-index repo? llama_hub as a repo is now deprecated

@rwood-97
Copy link
Contributor Author

Hey sorry, I ran out of time getting this done on Friday but have blocked off some time on Wednesday next week to do this plus migrate our repo to the new llama-index.

Part of the problem was that the github repo reader had lost some functionality in the llama_index repo vs llama_hub so I was going to tackle that but it looks like its been done already (thanks!):
run-llama/llama_index#10953
run-llama/llama_index#10949

Hopefully this PR will now be simpler to transfer across, I'll close it when I've made the PR there just to keep track if thats okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants