Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt labels to kubernetes recommended ones #455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonitich
Copy link

what

  • Set Kubernetes recommended labels.

why

  • Align standards.

tests

  • I've testes it by rendering the helm chart.

@jonitich jonitich requested a review from a team as a code owner February 11, 2025 13:43
Signed-off-by: Jonatan Redondo <joniredondo@gmail.com>
Copy link
Member

@GMartinez-Sisti GMartinez-Sisti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jonitich, thank you for the contribution, unfortunately users might be matching the current labels so we can't remove them.

I'll bring this to a discussion on the community so we can decide if it's worth a breaking change, a feature toggle or if it won't go through. I'll update the slack thread id here.

Update: slack thread -> https://cloud-native.slack.com/archives/C07T45G27EZ/p1739283078077209

@GMartinez-Sisti GMartinez-Sisti changed the title Adapt labels to kuberentes recommended ones Adapt labels to kubernetes recommended ones Feb 11, 2025
@jonitich
Copy link
Author

Thanks for the quick response @GMartinez-Sisti,
Br,
Joni.

@jonitich
Copy link
Author

hi @GMartinez-Sisti, I can see tthe Lint adn Test Charts failing, is there anything I can do about it?

@GMartinez-Sisti
Copy link
Member

hi @GMartinez-Sisti, I can see tthe Lint adn Test Charts failing, is there anything I can do about it?

The error is:

✖︎ atlantis => (version: "5.14.0", path: "charts/atlantis") > chart version not ok. Needs a version bump!

This version bump would be dependent on how this PR will be categorized. So no need to worry about this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants