Update pvp-performance-tracker to v1.7.1 #9084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new UI labels, many refactors for maintainability Support for god spells, special attacks for arkan blade, burning claws & dark bow. Double deaths now tracked. New statistic labels & improved tooltips. Various calculation & detection improvements. Renamed Deserved damage to Expected damage.
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #9050, apparently when I force push while it's closed you can't re-open (ty again to sacca for spotting an issue with my ui migration)
Most of the functional changes: Support for god spells, special attacks for arkan blade, burning claws & dark bow. Double deaths now tracked. New statistic labels & improved tooltips. Various calculation & detection improvements. Renamed Deserved damage to Expected damage. Thanks to sacca for many PRs here
Many refactors to help with maintainability in the future, regarding UI generation. Here are some custom diff links to hopefully help review. Let me know if you have any questions, or if we'd rather split this into multiple PRs, but I think with these seperate diff links it should be okay. Either way, I understand if it takes a while to review.
[0]->[1]: Most of the functional changes, basically the old/current hash up to right before the UI reworks and deservedDmg renames: Matsyir/pvp-performance-tracker@43799b3...Matsyir:cd22da8bcda50a06cf9f5ecc10fe88a43fb8ba8c [12files, +230, -77]
[1]->[2]: Most of the UI reworks, before deservedDmg rename (excluding initial functional changes): Matsyir/pvp-performance-tracker@cd22da8...Matsyir:6041bf5f323483bf72cdb0cfdbae3855445b224b [12files, +1,462, -561] (this part is way bigger than I expected, surprised its not removing more than adding; but pretty straightforward to understand i think)
[2]->[3]: Renaming Deserved Damage -> Expected Damage, plus the few small remaining commits of fixes/tooltip adjustments (excluding the last 2 batches): Matsyir/pvp-performance-tracker@6041bf5...Matsyir:69ac80a72cb7797d0bdb802bdca0d960cd3033f6 [15files, +253, -231]
Commit hashes used:
[0]:
43799b39409d9dfd8e20c72ba3f90d4e20e501dd(this is the old/currently live hash)[1]:
cd22da8bcda50a06cf9f5ecc10fe88a43fb8ba8c(before ui reworks)[2]:
6041bf5f323483bf72cdb0cfdbae3855445b224b(after ui reworks/before deservedDamage rename)[3]:
69ac80a72cb7797d0bdb802bdca0d960cd3033f6(this is the new hash being commit here)Here is a screenshot of the new UI label (not the biggest addition for how big of a refactor this was, but it will be easier to maintain). For the overlay, I properly took into consideration what happens when the left labels overlap the middle label, it's fine and not too instrusive due to the way it's layered, and they have low opacity. For the panel, it just doesn't really happen in practice, but it does also handle it relatively gracefully.
