Add Port Roberts Thieving Helper

[mkwozniak]

A plugin which assists thieving at Port Roberts stalls.
I'm not sure if it's something worth adding to Runelite but I had a lot of fun making it so I thought it might be worth a try.

Features

• Shows boxes around each stall when they are being watched.
• Shows boxes around each stall when they are safe to steal from.
• Can send an OS notification when a toggled stall is safe to steal from.
• Can flash the screen when a toggled stall is safe to steal from.
• Can play a sound for when a toggled stall is being watched, and a separate sound for when it's safe to steal from.
• Toggle notifications for each stall

Config

[runelite-github-app]

New plugin portrobertsthievinghelper: https://github.com/mkwozniak/OSRSPortRobertsThievingHelper/tree/2b9425b982fdf54ab32a3794e7961cb95266d3d4

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[riktenx]

• don't re-check NPC locations every client tick, that's 50 times a second for something which only updates every 0.6 seconds, you want onGameTick
• clear your tracked NPCs on plugin shutdown, both guards and activeGuards. IDK what the purpose even is of activeGuards, you don't seem to do anything with it, maybe just remove that

[mkwozniak]

• don't re-check NPC locations every client tick, that's 50 times a second for something which only updates every 0.6 seconds, you want onGameTick

  • clear your tracked NPCs on plugin shutdown, both guards and activeGuards. IDK what the purpose even is of activeGuards, you don't seem to do anything with it, maybe just remove that

Yeah you're totally right I can just use the guards list instead and remove that set. Thanks. I'll make those changes, do another test and pr

[riktenx]

Don't do another PR, just update the commit hash here