Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: add attack range parsing #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylerwgrass
Copy link
Member

@tylerwgrass tylerwgrass commented Aug 30, 2024

Adding scraping for attack range as it's the only missing stat for weapons.

Staves with cast mode (example) have attackrange=staff, but all others have a number range.
Not sure if there's a better alternative than the override I used here.

  "22294": {
    "name": "Uncharged toxic trident (e)",
    "weight": 1.814,
    "equipable": true,
    "equipment": {
      "slot": 3,
      "amagic": 25,
      "dstab": 2,
      "dslash": 3,
      "dcrush": 1,
      "dmagic": 15,
      "attackrange": 7,
      "aspeed": 4
    },
    "ge_limit": 8
  },
  "22296": {
    "name": "Staff of light",
    "weight": 1.5,
    "equipable": true,
    "equipment": {
      "slot": 3,
      "astab": 55,
      "aslash": 70,
      "amagic": 17,
      "dslash": 3,
      "dcrush": 3,
      "dmagic": 17,
      "str": 72,
      "attackrange": 1,
      "aspeed": 4,
      "mdmg": 15.0
    },
    "ge_limit": 8
  },

@abextm
Copy link
Member

abextm commented Aug 30, 2024

Do you have a matching pr for arn and the client for this?

@tylerwgrass
Copy link
Member Author

Not yet, I’ll open them

@tylerwgrass
Copy link
Member Author

tylerwgrass commented Aug 30, 2024

runelite/runelite#18209

@tylerwgrass tylerwgrass force-pushed the add-attack-range-parsing branch from da4163c to 82bee57 Compare February 22, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants