chore: replace ascii-box-check with skillshare skill in hub registry#3
chore: replace ascii-box-check with skillshare skill in hub registry#3
Conversation
Remove ascii-box-check skill and add the built-in skillshare skill for installing, searching, and managing skills from the hub.
Summary of ChangesHello @runkids, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the skill registry by removing an outdated entry and integrating a new, foundational built-in skill. This change aims to streamline the available skills and enhance the platform's core functionality for skill management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the ascii-box-check skill with the new skillshare skill in the hub registry. The change is straightforward, but the new skillshare entry introduces a data format for defining a skill's source that is inconsistent with other entries in the file. I've suggested a change to align it with the existing format to improve the maintainability and consistency of the hub file.
| { | ||
| "name": "skillshare", | ||
| "description": "Built-in AI skill for skillshare – helps install, search, and manage skills from the hub", | ||
| "source": "https://github.com/runkids/skillshare/tree/main/skills/skillshare", | ||
| "tags": [ | ||
| "skillshare", | ||
| "agent", | ||
| "skill" | ||
| ] | ||
| } |
There was a problem hiding this comment.
For consistency with other entries in this file, I suggest defining the source and skill properties for the new skillshare skill using the established owner/repo pattern. The current use of a full URL for source and the omission of the skill property introduces a new format, which can make parsing and maintenance of this file more complex. Adhering to a single pattern improves maintainability.
{
"name": "skillshare",
"description": "Built-in AI skill for skillshare – helps install, search, and manage skills from the hub",
"source": "runkids/skillshare",
"skill": "skillshare",
"tags": [
"skillshare",
"agent",
"skill"
]
}The audit script now handles all source formats: - GitHub browser URL: https://github.com/owner/repo/tree/branch/path - GitHub domain shorthand: github.com/owner/repo/path - GitHub shorthand: owner/repo/path - Plain HTTP URLs (non-GitHub) For sources with subpaths, only the subdirectory is audited instead of the entire cloned repo.
- Remove skillshare init workaround (path mode no longer needs config) - Switch audit.sh from sed/awk text parsing to --json + jq for reliable risk extraction - Add Gitea/Forgejo URL parsing (src/branch/ pattern) for non-GitHub skill sources - Add duplicate source validation in validate.sh
runkids
force-pushed
the
modify-default-skill
branch
from
c32871d to
b18c28e
Compare
Skill Audit Results
Audit Details
|
1 participant
Remove ascii-box-check skill and add the built-in skillshare skill for installing, searching, and managing skills from the hub.