ci: auto-build hub.json and fix duplicate source validation#5
Conversation
- CI now auto-commits skillshare-hub.json when skills/*.json changes (contributors no longer need to run make build) - Fix validate.sh duplicate source check to use source+skill combo (allows multiple skills from same repo with different skill fields) - Update CONTRIBUTING.md: simplify workflow, add category split rule - Update PR template: remove manual build checklist item
Summary of ChangesHello @runkids, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the developer experience and validation robustness for the skill-sharing hub. It automates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No new or changed skill sources to audit. |
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to the contributor workflow and the validation process. Automating the skillshare-hub.json build in CI removes a manual step for contributors, making the process smoother. The updated duplicate source validation logic correctly accounts for multi-skill repositories by combining source and skill fields, which is a crucial correctness fix. Furthermore, the CONTRIBUTING.md file has been simplified and clarified with new category rules, enhancing maintainability and ease of use for new contributors. Overall, these changes are well-implemented and positively impact the project's usability and integrity.
Summary
skillshare-hub.jsonwhenskills/*.jsonchanges — contributors no longer needmake buildvalidate.shduplicate source check: usesource + skillcombo (allowsskill-creatorandtemplate-skillto shareanthropics/skillssource)community.jsonmake build" from PR template checklistChanges
.github/workflows/validate-pr.ymlcontents: write, checkout PR branch, auto-commit stepscripts/validate.shsource + skillcomboCONTRIBUTING.md.github/PULL_REQUEST_TEMPLATE.mdTest plan