Update async job streaming stop condition and test cases #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zealotjin
changed the title
Yhlong00
reviewed
Mar 25, 2025
| if stream_partial["status"] not in FINAL_STATES: | ||
| if ( | ||
| stream_partial["status"] not in FINAL_STATES | ||
| or len(stream_partial["stream"]) > 0 |
Contributor
There was a problem hiding this comment.
or len(stream_partial.get("stream", [])) > 0
Yhlong00
approved these changes
Mar 25, 2025
deanq
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async job's streaming method runs indefinitely without specifically calling a break outside of the function.
This change handles the break when the job is complete AND all the stream data has been consumed. (The stop condition should check for the
{status: "COMPLETED", stream: []}job response.This is in sync with the runner stream implementation. The test case has also been updated.