Bug: Fixing worker-state initialization bug #427
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running
runpod --helpcrashes the runpod python sdk b/c we are starting a multithreaded process is causing the crash.The fix is to not create the object until methods are specifically called. So at initialization we should initialize to
Noneand only when the classes are acted on, do we initialize and member variables for multithreadingDebug Stack:
Error when I ran --help
The main thing to look at is:
Looking deeper into why the reasoning is:
rp_job.pyHow to Test:
I wasn't sure how to test, so I just ran the tests again and had tests generated by claude for --help command for sanity test in the future.
Passing status quo cases
Showing that without the fix we can capture --help errors in the future: