Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eip4844 Point Evaluation precompile #2701

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Eip4844 Point Evaluation precompile #2701

merged 11 commits into from
Feb 10, 2025

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Feb 3, 2025

This PR implements the point evaluation precompile for EIP-4844. It relies on this PR, that implements a new hook for verify_kzg_proof in the blockchain-k-plugin.

@mariaKt mariaKt changed the title Eip4844 pointevalprec Eip4844 Point Evaluation precompile Feb 4, 2025
@mariaKt mariaKt requested a review from dwightguth February 6, 2025 20:26
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion is to put BLS_MODULUS into a macro.

@mariaKt mariaKt requested a review from anvacaru February 6, 2025 21:05
@mariaKt
Copy link
Contributor Author

mariaKt commented Feb 6, 2025

@anvacaru since your review and addressing your comments, I have made a few small changes.

  • added a couple of side conditions to the rules, regarding conditions that the inputs need to satisfy.
  • changed a large constant that was used often to a macro.

Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mariaKt mariaKt merged commit 24787fb into master Feb 10, 2025
12 checks passed
@mariaKt mariaKt deleted the eip4844-pointevalprec branch February 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants