Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .PHONY target #361

Closed
wants to merge 1 commit into from
Closed

Update .PHONY target #361

wants to merge 1 commit into from

Conversation

hjorthjort
Copy link
Contributor

See finding explained here: kframework/ewasm-semantics#26 (comment)

@hjorthjort hjorthjort requested a review from ehildenb June 14, 2020 11:09
@hjorthjort
Copy link
Contributor Author

I don't really see why make wouldn't resolve match the build-llvm and build-haskell targets against the build-% target.
I'm not sure, however, that adding the build-% target achieves anything. The dependency checks in the build of the ewasm-semantics work just as well when build-% isn't declared .PHONY at all.

@ehildenb
Copy link
Member

@hjorthjort this change doesn't make sense here, build-llvm and build-haskell are explicitly declared in the Makefile here.

I don't think adding build-% is doing what you think in the ewasm semantics. The % in make is not a wildcard, it's a pattern match. So if you don't have a % on the LHS of the :, it is being populated with nothing. So I'm pretty sure you're just adding build- to the .PHONY there.

In your ewasm PR you can have:

.PHONY: build

build: build-llvm build-haskell

build-%: ...

So that we can do make build to get the most common builds, have build be .PHONY, and have the one rule for build-%.

Though, honestly, I'm inclined to say you should just have explicit build-llvm and build-haskell targets in the ewasm makefile. Your choice though.

Anyway, this one can be closed I think.

@hjorthjort hjorthjort closed this Jun 14, 2020
rv-jenkins added a commit that referenced this pull request Sep 9, 2020
…b - Add \left-assoc and \right-assoc to llvm backend (#361) (#1543)
rv-jenkins added a commit that referenced this pull request Nov 18, 2020
* deps/k: 3db678b5d - llvm-backend/src/main/native/llvm-backend: f6bcdc6 - New function encoding (#330) (#1541)

* deps/k: a05e61809 - Add missing check and update error message (#1540)

* deps/k: 5e4e023e9 - llvm-backend/src/main/native/llvm-backend: a85705b - Add \left-assoc and \right-assoc to llvm backend (#361) (#1543)

* kwasm-lemmas: add missing simplification annotations

* deps/k: eda9f3116 - llvm-backend/src/main/native/llvm-backend: a6b7d17 - ffi: do not consider at_quick_exit a private symbol on OSX (#364) (#1581)

* deps/k: 028ecbadb - Warn if user imports module with not-lr1 attribute when doing LR(1) parsing (#1583)

* deps/k: 0e1f299d5 - Use `claim` keyword for proof obligations (#1553)

* deps/k: fec135048 - Fix kore claims missing location info (#1586)

* deps/k: 2b4c1e896 - Forbid functions in LHS outside simplification rules (#1588)

* deps/k: a6ebbac91 - llvm-backend/src/main/native/llvm-backend: 239c820 - KREFLECTION.argv (#365) (#1601)

* deps/k: 2cbe065c0 - llvm-backend/src/main/native/llvm-backend: 4a37f2f - fix bug involving garbage collection (#368) (#1606)

* deps/k: 23f5bf141 - Rule2claim (#1608)

* deps/k: adb796dd1 - Apply minor fixes to kx (#1596)

* deps/k: 496c0b5ab - haskell-backend/src/main/native/haskell-backend: 07e93185 - Save proofs even when successful (#2197) (#1616)

* deps/k: 665963964 - don't import internal jdk package (#1622)

* deps/k: 489da3f6f - Fine tune function checks (#1619)

* deps/k: 895710675 - haskell-backend/src/main/native/haskell-backend: 9a77ee5c - Fix SideCondition normalization error (#2239) (#1627)

* deps/k: 5a16fef77 - web/pages: remove join the k team link (#1638)

* deps/k: ada1ae851 - Improve error message for PriorityFilter. (#1639)

* deps/k: 258d7017a - Better defined ARRAY Lookup (#1637)

* deps/k: 430b122eb - Bump junit from 4.12 to 4.13.1 in /java-backend (#1589)

* deps/k: 2fcc478e7 - fix concrete function test to not expand builtin sort (#1649)

* deps/k: 1b088841c - Pyk updates for gas expression manipulation (#1610)

* deps/k: d0aa1492f - CNAME (#1654)

* rule => claim

* bigfix: missing simplification attribute

* remove #if

* fix indentations in proofs

* remove claim (added by mistake)

Co-authored-by: hjorthjort <rikard.hjort@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants