Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pull Request Compliance Checker #2389

Closed
3 tasks done
CBID2 opened this issue Jun 5, 2024 · 7 comments · Fixed by #2469
Closed
3 tasks done

[Feature] Pull Request Compliance Checker #2389

CBID2 opened this issue Jun 5, 2024 · 7 comments · Fixed by #2469
Assignees
Labels
priority: high Making completely new feature 🚀 ready

Comments

@CBID2
Copy link
Collaborator

CBID2 commented Jun 5, 2024

Description

Problem

There has been a recurring issue with first-time contributors submitting pull requests without completing the form.

Solution

OpenSauced uses a compliance workflow, and it's been helpful with checking for incomplete PR forms.

Note

I tested this myself in a test-repo that I created, and it worked(see photos in the screenshots section for more context).

Screenshots

the pull request from my test repo
results of the first test

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@CBID2 CBID2 added the priority: high Making completely new feature label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Hello CBID2!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@CBID2
Copy link
Collaborator Author

CBID2 commented Jun 8, 2024

@Anmol-Baranwal, @aftabrehan
, and @rupali-codes, what do you think?

@Anmol-Baranwal
Copy link
Collaborator

@Anmol-Baranwal, @aftabrehan , and @rupali-codes, what do you think?

I'm still not clear on what it does, I mean the forms are in .yml format so beginners shouldn't face any problems.
That is the minimum requirement if anyone want to communicate in open source.

@CBID2
Copy link
Collaborator Author

CBID2 commented Jul 1, 2024

@Anmol-Baranwal, @aftabrehan , and @rupali-codes, what do you think?

I'm still not clear on what it does, I mean the forms are in .yml format so beginners shouldn't face any problems. That is the minimum requirement if anyone want to communicate in open source.

PR compliance warning

It's meant to warn contributors that they have'nt filled out their PRs effectively. I've seen this work at OpenSauced.

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes @CBID2
I think we should go for this. At least the basic requirements like issue will be linked properly!

@rupali-codes
Copy link
Owner

@CBID2 it seems pretty valid, assigning to you!

Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Making completely new feature 🚀 ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants