Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iconse feature added #2396

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Iconse feature added #2396

merged 1 commit into from
Jul 17, 2024

Conversation

Riyazul555
Copy link

Fixes Issue #2382

Changes proposed

Screenshots

Note to reviewers

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:41pm

@github-actions github-actions bot added goal: new-feature New feature or request priority: high Making completely new feature labels Jun 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Riyazul555, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Riyazul555
Copy link
Author

@rupali-codes please review this pR
Thanks

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
I think it's important to mention that it is necessary to fill out the fields; otherwise, there is no purpose in having them. Perhaps we can remove it from the pull request template. Contributors often don't even link the PR properly, even though it is clearly explained how to do so.

@CBID2
Copy link
Collaborator

CBID2 commented Jul 1, 2024

@rupali-codes I think it's important to mention that it is necessary to fill out the fields; otherwise, there is no purpose in having them. Perhaps we can remove it from the pull request template. Contributors often don't even link the PR properly, even though it is clearly explained how to do so.

Hey @Anmol-Baranwal. I actually raised an issue about this. Check #2389

@rupali-codes rupali-codes merged commit ff895f9 into rupali-codes:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request priority: high Making completely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants