Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extended gap in title and description #1055

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

Resolves #1050

Description

  • I have fixed the following bug in title on popup:
Previous Current
Screenshot 2023-06-16 153006 image

Note to reviewers

@rupali-codes @ujjawaltyagii
I need your help, so the issue is that the description in the Card is slightly longer, and I have properly debug the code on various components.

This image shows the problem
image

So, on changing

- className="w-full cursor-pointer transition-all duration-100 ease-in hover:scale-[1.02] md:w-72"
+ className="cursor-pointer transition-all duration-100 ease-in hover:scale-[1.02] md:w-50"

in CardListItem.tsx

The gap is fixed as shown below:
image

But this solution doesn't meet my intended goal. Could you provide any ideas or approaches to address this issue?

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 0:16am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2
CBID2 previously approved these changes Jun 16, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this helps

@rupali-codes
Copy link
Owner

@Anmol-Baranwal hi, so for the cards like this, i guess it would be better if we can align the text to left for all cards? what do you you think?

image

@rupali-codes rupali-codes added bug Something isn't working gssoc GirlScript Summer of Code participants level2 Modifying an existing feature labels Jun 17, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

@Anmol-Baranwal hi, so for the cards like this, i guess it would be better if we can align the text to left for all cards? what do you you think?

image

I have already described the issue in the pr comment on what I reached after debugging, so are you suggesting to align it on left but it would still not fix the issue, because i literally added 'hey' in between the gap while testing. Please clarify further.

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
Please provide clarification.

@rupali-codes
Copy link
Owner

@rupali-codes Please provide clarification.

I guess, it would be better if we add a gap between the words than using text-justify because its adding unnecessary extra space, or let me know what do you think about it

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes Please provide clarification.

I guess, it would be better if we add a gap between the words than using text-justify because its adding unnecessary extra space, or let me know what do you think about it

I will complete the remaining PRs after tomorrow's exam, by the 24th.

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes Please provide clarification.

I guess, it would be better if we add a gap between the words than using text-justify because its adding unnecessary extra space, or let me know what do you think about it

There is no text-justify used in codebase, and it seems that the styles are overlapping each other. As a result, I'm unable to make any significant changes to resolve this issue. This problem may be attributed to the fixed size of the card.

Can you please look again.

@rupali-codes
Copy link
Owner

@rupali-codes Please provide clarification.

I guess, it would be better if we add a gap between the words than using text-justify because its adding unnecessary extra space, or let me know what do you think about it

There is no text-justify used in codebase, and it seems that the styles are overlapping each other. As a result, I'm unable to make any significant changes to resolve this issue. This problem may be attributed to the fixed size of the card.

Can you please look again.

Its coming from here actually,

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ujjawaltyagii
Copy link
Contributor

Looking good

Ig he is not done with the final changes as i can still see the unusual gaps in resource description

@CBID2
Copy link
Collaborator

CBID2 commented Jun 30, 2023

Looking good

Ig he is not done with the final changes as i can still see the unusual gaps in resource description

Hence why I chose the general comment option 😊

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
On removing it as per your suggestion, the design looks like this. Please let me know if this design is acceptable or if the current one works better.

Without Removing
image

Removing
image

@rupali-codes
Copy link
Owner

the second one looks much better to me

@Anmol-Baranwal
Copy link
Collaborator Author

Anmol-Baranwal commented Jul 1, 2023

the second one looks much better to me

I have done the changes as per your preference, the problem was styles in globals.css was at higher priority, so I changed the tag from p to div

@rupali-codes
Copy link
Owner

the second one looks much better to me

I have done the changes as per your preference, the problem was styles in globals.css was at higher priority, so I changed the tag from p to div

Thanks, looks nice to me

@rupali-codes rupali-codes merged commit 9d5ef5c into rupali-codes:main Jul 1, 2023
3 checks passed
@Anmol-Baranwal Anmol-Baranwal deleted the hack_letter_spacing branch July 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc GirlScript Summer of Code participants level2 Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix letter spacing for resource content
4 participants