-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extended gap in title and description #1055
fix: extended gap in title and description #1055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this helps
@Anmol-Baranwal hi, so for the cards like this, i guess it would be better if we can align the text to left for all cards? what do you you think? |
I have already described the issue in the pr comment on what I reached after debugging, so are you suggesting to align it on left but it would still not fix the issue, because i literally added 'hey' in between the gap while testing. Please clarify further. |
@rupali-codes |
I guess, it would be better if we add a gap between the words than using text-justify because its adding unnecessary extra space, or let me know what do you think about it |
I will complete the remaining PRs after tomorrow's exam, by the 24th. |
There is no
|
Its coming from here actually, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Ig he is not done with the final changes as i can still see the unusual gaps in resource description |
Hence why I chose the general comment option 😊 |
@rupali-codes |
the second one looks much better to me |
I have done the changes as per your preference, the problem was styles in |
Thanks, looks nice to me |
Fixes Issue
Resolves #1050
Description
Note to reviewers
@rupali-codes @ujjawaltyagii
I need your help, so the issue is that the description in the
Card
is slightly longer, and I have properly debug the code on various components.So, on changing
in
CardListItem.tsx
But this solution doesn't meet my intended goal. Could you provide any ideas or approaches to address this issue?