Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add DaFont to frontend/font category #1249

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

ahorisaac
Copy link
Contributor

Fixes Issue

Closes #1204

Changes proposed

I added DaFont to the fonts subcategory of the frontend category.

Screenshots

Screenshot 2023-07-07 19 29 46

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 6:34pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, AhorIsaac, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2 CBID2 added goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Jul 7, 2023
@k-deepak04
Copy link
Contributor

k-deepak04 commented Jul 8, 2023

@CBID2 @rupali-codes please merge this i'm not getting any option to merge

image

@CBID2
Copy link
Collaborator

CBID2 commented Jul 8, 2023

@CBID2 @rupali-codes please merge this i'm not getting any option to merge

image

Unfortunately @k-deepak04, I don't have access to Linkshub's Vercel account so we'll have to wait for @rupali-codes' response.

@k-deepak04
Copy link
Contributor

@rupali-codes merge this one too

@rupali-codes
Copy link
Owner

@CBID2 we have resolved this merge issue before, idk why its coming again 👀

@rupali-codes rupali-codes merged commit 41d9538 into rupali-codes:main Jul 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] <DaFont to the font category>
4 participants