Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck #1493

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Spellcheck #1493

merged 5 commits into from
Aug 8, 2023

Conversation

k-deepak04
Copy link
Contributor

@k-deepak04 k-deepak04 commented Aug 4, 2023 •
edited by CBID2
Loading

Issues

Closes #1080

Changes proposed

The GitHub Action will now automatically run codespell on your JSON files every time you push to the main branch or open a new pull request. If it detects any spelling errors, the Action will fail, indicating that you need to fix the identified issues.

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2023 10:36am

github-actions[bot]
github-actions bot reviewed Aug 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, k-deepak04, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@k-deepak04
Copy link
Contributor Author

@CBID2 have a look at this once.
tried this for you 🙌

@CBID2
Copy link
Collaborator

CBID2 commented Aug 4, 2023

@CBID2 have a look at this once.

tried this for you 🙌

Have you ran it locally? That's the problem I had

@k-deepak04
Copy link
Contributor Author

@CBID2 have a look at this once.
tried this for you 🙌

Have you ran it locally? That's the problem I had

yep tried i have attached the ss in the issue one kindly check

@CBID2
Copy link
Collaborator

CBID2 commented Aug 4, 2023

@CBID2 have a look at this once.

tried this for you 🙌

Have you ran it locally? That's the problem I had

yep tried i have attached the ss in the issue one kindly check

Ok

@CBID2
Copy link
Collaborator

CBID2 commented Aug 4, 2023

@CBID2 have a look at this once.

tried this for you 🙌

Have you ran it locally? That's the problem I had

yep tried i have attached the ss in the issue one kindly check

I don't see it

@k-deepak04
Copy link
Contributor Author

check #1174 for ss, i have moulded this one for testing the JSON file only as the contributors write's description mainly in that file.

@CBID2
Copy link
Collaborator

CBID2 commented Aug 4, 2023

So should I close this one?

@k-deepak04
Copy link
Contributor Author

So should I close this one?

guess so by merging this pr, it will detect the errors most probably, pmeanwhile you can close that issue and assign me add label to this pr :)

CBID2
CBID2 previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-deepak04
Copy link
Contributor Author

@rupali-codes please review this one too

@k-deepak04
Copy link
Contributor Author

@CBID2 please add tags on this pr :)

@CBID2 CBID2 self-assigned this Aug 4, 2023
@CBID2 CBID2 added goal: new-feature New feature or request gssoc GirlScript Summer of Code participants level3 Making completely new feature collab Open to collaborate with another contributor and/or maintainer labels Aug 4, 2023
rupali-codes
rupali-codes reviewed Aug 5, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-deepak04 we had some issues previously, hope you've tested it well?

@rupali-codes
Copy link
Owner

@k-deepak04 please remove the commit of your another PR (adding new maintainer)

@k-deepak04
Copy link
Contributor Author

@k-deepak04 please remove the commit of your another PR (adding new maintainer)

okay

@k-deepak04
Copy link
Contributor Author

@rupali-codes check now

@k-deepak04
Copy link
Contributor Author

@rupali-codes please check and merge

@rupali-codes rupali-codes merged commit b552ec6 into main Aug 8, 2023
5 checks passed
@rupali-codes rupali-codes deleted the spellcheck branch August 8, 2023 18:11
@k-deepak04 k-deepak04 restored the spellcheck branch August 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@rupali-codes rupali-codes rupali-codes approved these changes

@CBID2 CBID2 CBID2 left review comments

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

Assignees

@k-deepak04 k-deepak04

@CBID2 CBID2

Labels
collab Open to collaborate with another contributor and/or maintainer goal: new-feature New feature or request gssoc GirlScript Summer of Code participants level3 Making completely new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] GitHub Action to catch spelling errors
3 participants
@k-deepak04 @CBID2 @rupali-codes