Added CTA And Made Sidebar take whole space

[Souravvmishra]

Fixes

Closes #1448

Changes proposed

1. Added CTA
2. Made Sidebar Take Full Space

Screenshots

Note to reviewers

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
linkshub	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 5:46am

[github-actions]

Thank you, Souravvmishra, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

[Souravvmishra]

@rupali-codes Reviews are appreciated

[CBID2]

I could not see the changes when I went to the preview site @Souravvmishra(see screenshot below). Can you fix this?

[Souravvmishra]

This is because it is available only on small screens devices.

[CBID2]

LGTM

[k-deepak04]

@rupali-codes @CBID2 as far my experience it's not that much suitable to add full side panel that covers the whole screen

as you can see this big brands also use the 70% ration of the hamburger menu......
rest your call........this is my opinion

[CBID2]

Did you do it on a small screen @k-deepak04? That's what it's for.

[k-deepak04]

Did you do it on a small screen @k-deepak04? That's what it's for.

yep christy all the ss are from small screens only
mobile tablets comes under small screens category
and i have added ss of those.......

[CBID2]

Did you do it on a small screen @k-deepak04? That's what it's for.

yep christy all the ss are from small screens only

mobile tablets comes under small screens category

and i have added ss of those.......

Ah ok. It seemed to work on my phone.

[rupali-codes]

@Souravvmishra hi thanks. Can you make it for mobile screens only? not for tablet and all?

[Souravvmishra]

Its build as per the design when the sidebar becomes hidden, we show a explore button.

[Souravvmishra]

@rupali-codes @CBID2 as far my experience it's not that much suitable to add full side panel that covers the whole screen

as you can see this big brands also use the 70% ration of the hamburger menu......
rest your call........this is my opinion

These Big Brands are using the sidebar as a sidebar for extra options but in our case, our sidebar has all the Focus of the user

[k-deepak04]

@rupali-codes @CBID2 as far my experience it's not that much suitable to add full side panel that covers the whole screen



as you can see this big brands also use the 70% ration of the hamburger menu......
rest your call........this is my opinion

These Big Brands are using the sidebar as a sidebar for extra options but in our case, our sidebar has all the Focus of the user

okay man :)
no issues just make that for mobile not for tablets as said by rupali then we are good to go

[Souravvmishra]

Its build as per the design when the sidebar becomes hidden, we show a explore button.

Are You Sure You Want To Remove It For Tablets?
In tablets, the sidebar is hidden, So We Need The CTA

[Souravvmishra]

can you please merge this

[CBID2]

@rupali-codes?

[rupali-codes]

@Souravvmishra can we do it only for mobile screens? not for tablets and all?

[Anmol-Baranwal]

It should be for small screen devices only.

Also, can you explain why full screen sidebar is better? I don't want assumptions. Say from the perspective of a user.

[k-deepak04]

@Souravvmishra please tell why full screen is needed , as rightly said by anmol also have you did only for mobile not for tabs as requested by rupali?
If not please do it

[Anmol-Baranwal]

@Souravvmishra
If you are not interested in solving the issue. Kindly let me know, so that I can close the pull request.

[Souravvmishra]

Apologies for the late reply, I am on a trip.

Why do we need a full screen?
Because a semi sidebar gives the perception of a less important component. True that many big companies use a semi sidebar but they simply use that as a sidebar for some extra things but in our case, Sidebar is the main component. We need maximum importance to that.

Actually I would Suggest Creating a new page instead of just using the sidebar

These all work for small screens only as in the large screen the sidebar is already visible. So at least the user is aware of it. But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

[Anmol-Baranwal]

Apologies for the late reply, I am on a trip.

Why do we need a full screen? Because a semi sidebar gives the perception of a less important component. True that many big companies use a semi sidebar but they simply use that as a sidebar for some extra things but in our case, Sidebar is the main component. We need maximum importance to that.

Actually I would Suggest Creating a new page instead of just using the sidebar

These all work for small screens only as in the large screen the sidebar is already visible. So at least the user is aware of it. But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

Feel free to reply whenever you have time. No rush!

I don't understand this:

But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

@rupali-codes @CBID2 @k-deepak04
What do guys think?

[CBID2]

Apologies for the late reply, I am on a trip.

Why do we need a full screen? Because a semi sidebar gives the perception of a less important component. True that many big companies use a semi sidebar but they simply use that as a sidebar for some extra things but in our case, Sidebar is the main component. We need maximum importance to that.

Actually I would Suggest Creating a new page instead of just using the sidebar

These all work for small screens only as in the large screen the sidebar is already visible. So at least the user is aware of it. But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

Feel free to reply whenever you have time. No rush!

I don't understand this:

But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

@rupali-codes @CBID2 @k-deepak04

What do guys think?

I'm lost too @Anmol-Baranwal

[k-deepak04]

Apologies for the late reply, I am on a trip.

Why do we need a full screen? Because a semi sidebar gives the perception of a less important component. True that many big companies use a semi sidebar but they simply use that as a sidebar for some extra things but in our case, Sidebar is the main component. We need maximum importance to that.

Actually I would Suggest Creating a new page instead of just using the sidebar

These all work for small screens only as in the large screen the sidebar is already visible. So at least the user is aware of it. But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

Feel free to reply whenever you have time. No rush!
I don't understand this:

But in small screen, the user has no idea that they are in sidebar. Yes it is written but who reads?

@rupali-codes @CBID2 @k-deepak04
What do guys think?

I'm lost too @Anmol-Baranwal

I think we should have one landing page then one for the categories from where user can go to the resources.
We had a discussion on it too right @rupali-codes ?

[rupali-codes]

@k-deepak04 yes we did, but still, how we actually going render resources in there? its not like 5-10 resources that user can directly see on the screen, they will have to scroll. And having a landing page is completely a sperate idea, it was for where we can show other things, like About LinksHub, Contacting us, How people can contribute, showing contributors list etc etc.

Having the sidebar is not a problem, we just need to make it more accessible.

@Anmol-Baranwal & @CBID2 what are your takes on this?

[rupali-codes]

@Souravvmishra its showing 2 scrollbars in the sidebar, could you please check?

[Anmol-Baranwal]

@rupali-codes
When I made the PR to fix this searchbar, there was only one sidebar (which was very tough), but I did implement that.

Later, someone must have changed the code which removed that functionality.

See this: https://linkshub-1arqvr3it-rupali-codes.vercel.app/

Like, I did it properly.

[CBID2]

@k-deepak04 yes we did, but still, how we actually going render resources in there? its not like 5-10 resources that user can directly see on the screen, they will have to scroll. And having a landing page is completely a sperate idea, it was for where we can show other things, like About LinksHub, Contacting us, How people can contribute, showing contributors list etc etc.

Having the sidebar is not a problem, we just need to make it more accessible.

@Anmol-Baranwal & @CBID2 what are your takes on this?

I agree @rupali-codes

[CBID2]

How are we going to move forward with this @rupali-codes and @Anmol-Baranwal?

[Anmol-Baranwal]

Don't know, @rupali-codes must be active.

[rupali-codes]

Don't know, @rupali-codes must be active.

can we just keep this PR to add CTA and keep the sidebar as it is currently?

[CBID2]

Don't know, @rupali-codes must be active.

can we just keep this PR to add CTA and keep the sidebar as it is currently?

That's not a bad idea @rupali-codes. What do you think @Anmol-Baranwal?

[CBID2]

Closed due to inactivity