Skip to content

[BUGFIX] #58 Respect storage_pid if useStoragePid is enabled in EXTCONF#59

Closed
LeoniePhiline wants to merge 6 commits intorupertgermann:masterfrom
LeoniePhiline:master
Closed

[BUGFIX] #58 Respect storage_pid if useStoragePid is enabled in EXTCONF#59
LeoniePhiline wants to merge 6 commits intorupertgermann:masterfrom
LeoniePhiline:master

Conversation

@LeoniePhiline
Copy link

NOTE: Enabling useStoragePid means you need to have compatibility6 installed.
@see https://docs.typo3.org/typo3cms/extensions/core/Changelog/7.4/Deprecation-65790-PagesStoragePidDeprecated.html

\TYPO3\CMS\Backend\Utility\BackendUtility::getTCEFORM_TSconfig() can no
longer be used for determining the storage_pid, since this field is no
longer loaded by the internally used
\TYPO3\CMS\Backend\Utility\BackendUtility::getPageForRootline().

We are now figuring out the storage Pid ourselves, by traversing the
rootline.

LeoniePhiline and others added 3 commits March 14, 2017 23:40
…bled in EXTCONF

NOTE: Enabling useStoragePid means you need to have compatibility6 installed!
@see https://docs.typo3.org/typo3cms/extensions/core/Changelog/7.4/Deprecation-65790-PagesStoragePidDeprecated.html

\TYPO3\CMS\Backend\Utility\BackendUtility::getTCEFORM_TSconfig() can no
longer be used for determining the storage_pid, since this field is no
longer loaded by the internally used
\TYPO3\CMS\Backend\Utility\BackendUtility::getPageForRootline().

We are now figuring out the storage Pid ourselves, by traversing the
rootline.
@derhecht
Copy link
Collaborator

so compatibility6 has to be installed to work properly? no way!

@LeoniePhiline
Copy link
Author

Else you'll have to remove or rewrite all the useStoragePid related code.

Your extension offers use of the storage pid which has been moved into compatibility6.

If you don't want this optional compat feature to keep using tt_news with useStoragePid, then you've got lots of dead code in there.

@LeoniePhiline
Copy link
Author

Still this code only requires compatibility6 IF anyone wants or needs to keep using a setup involving tt_news and category sources defined by page.storage_pid.
If the extconf switch useStoragePid is off by default, then no compatibility6 is required.

A hint in the extconf labels and an "is compatibility6 installed?" when useStoragePid is found to be enabled, could help users.

@derhecht
Copy link
Collaborator

see approach in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants