Change return value of Module#alias_method #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
reviewed
Feb 28, 2021
| @@ -13,6 +30,12 @@ alias との違いは以下の通りです。 | |||
|
|
|||
| @param original 元のメソッド名。[[c:String]] または [[c:Symbol]] で指定します。 | |||
|
|
|||
| #@since 3.0.0 | |||
| @return メソッド名を表す Symbol を返します。 | |||
There was a problem hiding this comment.
「メソッド名を表す」だと新旧どちらのメソッド名が返るかパッと分かりづらいかなと思いました。「作成したエイリアスのメソッド名を表す Symbol を返します。」のようにすると明確かなと思うのですがどうでしょうか？
There was a problem hiding this comment.
ありがとうございます！修正してみました。
257af1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.0 で
Module#alias_methodの戻り値が変わったのでドキュメントに追加しました。参照