Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the developing docs more visible #8

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

TrialDragon
Copy link
Contributor

At the moment it's not entirely obvious where to find the relevant info on how to contribute, especially with how this site seems to use a lot of custom tech. Ideally it'd be in a CONTRIBUTING.md imo, but for now just linking to the current document in the README.md should help.

At the moment it's not entirely obvious to find the relevant info on how to contribute, especially with how this site seems to use a lot of custom tech.
@ChristopherBiscardi
Copy link
Contributor

Looks good to me, thanks.

I have to figure out how best to enable people to run locally. I think extracting a subset of the data from the database is going to be useful there, but some work needs to be done to make it easy.

Can you expand on what you mean by "lots of custom tech"? It would help me write documentation to enable other people.

@ChristopherBiscardi ChristopherBiscardi merged commit 6ce979b into rust-adventure:main Mar 7, 2024
@TrialDragon TrialDragon deleted the patch-1 branch March 7, 2024 17:02
@TrialDragon
Copy link
Contributor Author

Like everything seems unfamiliar. One of the first things I looked for is some sort of place where the content of pages would be by themselves, like with zola and other static site generators (then again i guess this isnt a static site generator aince i did see mentions of netlify?). Instead, it took looking thru the commit history to find some of it in the rust app, but not everything. Same for the css since I noticed some color contrast issues. I still don't know where or how to modify the css, doubly with the very... technical and not too readable for humans class definitions on the html.

@ChristopherBiscardi
Copy link
Contributor

@TrialDragon I totally understand being unfamiliar, I don't expect everyone to be familiar with all of the technology needed to operate a site like this. Rust and CSS are often at opposite ends in terms of people's skillsets, for example. I've opened #10 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants